Changes between Initial Version and Version 1 of Ticket #16850, comment 4


Ignore:
Timestamp:
2018-10-17T21:35:38+02:00 (7 years ago)
Author:
floscher

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16850, comment 4

    initial v1  
    11I now modified the patch to work with `Optional`s in `getNonBlankLayerName()`, also I remembered now that [https://pmd.github.io/pmd-6.8.0/pmd_rules_java_performance.html#inefficientemptystringcheck .trim().isEmpty() is inefficient]. The parameter of `createNewLayer()` is still a nullable `String`, there it shouldn't matter much if an Optional is passed through the convenience methods or a nullable string.
     2
     3By the way: I have patches for the plugins, which I'll propose after this is merged.