Changes between Version 1 and Version 2 of Ticket #16796, comment 5


Ignore:
Timestamp:
2019-10-18T22:28:01+02:00 (6 years ago)
Author:
Bjoeni

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16796, comment 5

    v1 v2  
    1313
    1414What needs to be done (at least) before applying this patch:
    15 - Gpx exporter doesn't work when asking if changes should be saved (upon closing/removal of a layer) due to threading problems
     15- ~~Gpx exporter doesn't work when asking if changes should be saved (upon closing/removal of a layer) due to threading problems~~
    1616- ~~Marker layers don't support colors anymore/yet~~
    17 - Add more tests for importer/exporter
     17- ~~Add more tests for importer/exporter~~
    1818- ~~Check Plugin compatibility~~ (Should probably be checked again before committing)
    1919- ~~No lines are drawn for unnamed new gpx tracks converted from data layers for some reason. This doesn't seem to be an issue with my patch though, same goes for the latest stable. Did someone change something there within the last few months? (haven't had a look at that yet, just noticed when creating the screenshots)~~
    2020
    2121Notes:
    22 - The determination of the needed namespaces for exporting and conversion between GPXX and GPXD isn't exactly beautiful.
     22- ~~The determination of the needed namespaces for exporting and conversion between GPXX and GPXD isn't exactly beautiful.~~
    2323- the opacity from the layer should also be saved in the files
    2424- ~~I'd suggest linking MarkerLayer and GpxLayer upon creation in order to allow the whole layer to be saved together again. Otherwise this might lead to a loss of markers if someone overrides the old file.~~
    2525- Not sure about the (visual) design in the ChooseTrackVisibilityDialog...
    2626- ~~In the long term I'd like to get rid of all layer specific settings in the preferences. Imo this is just poor design. The clr.layer.* ones are mostly removed, but the gps.raw.* ones still remain. Suggestion: Either save most of them as further JOSM extensions or just don't save these layer specific settings at all.~~ They are saved for Gpx layers now, should probably be implemented for other layers as well
    27 - The ImmutableGpxTrack isn't immutable anymore. I'd rename it and handle it like the MarkerLayer: The Interface GpxTrack.java becomes IGpxTrack.java and the Class ImmutableGpxTrack.java becomes GpxTrack.java (described as default implementation). This will inevitably lead to some issues since it's referenced by five Plugins, but I think that's worth it.
     27- ~~The ImmutableGpxTrack isn't immutable anymore. I'd rename it and handle it like the MarkerLayer: The Interface GpxTrack.java becomes IGpxTrack.java and the Class ImmutableGpxTrack.java becomes GpxTrack.java (described as default implementation). This will inevitably lead to some issues since it's referenced by five Plugins, but I think that's worth it.~~
    2828- Thank you for taking the time to read all of this.
    2929- The MarkerLayer is (unlike all the other layers) in layer/markerlayer/MarkerLayer.java and two MarkerLayerTests existed in layer/ and layer/markerlayer. I merged them to layer/markerlayer to match the source file structure but would actually put them both in layer/.