Changes between Version 7 and Version 8 of Ticket #16681


Ignore:
Timestamp:
2018-08-28T10:20:40+02:00 (7 years ago)
Author:
Bjoeni
Comment:

Replying to Don-vip:

Could you please see if you can extract the correlation logic outside of this class into a new one in the data.gpx package, and add unit tests for it (at least for the code you add)?

Done. I didn't implement unit tests for segments specifically, because the logic is absolutely similar to the tracks. I can add them if required.

I can change the labels if somebody suggests a string that makes somewhat sense. For the time being it is still tr("only when the segments are less than # minutes apart").split("#"); and similar

And do I have to add the new unit test test/unit/org/openstreetmap/josm/data/gpx/GpxImageCorrelationTest.java to an index somewhere?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16681 – Description

    v7 v8  
    1010- Option to temporarily force tagging of all pictures (by applying the settings above)
    1111- fixed bug that caused problems with empty segments or entire segments without waypoints
    12 - Set elevation and speed only when photo is actually within a track segment or interpolation is activated
     12- Set elevation and speed only when photo is actually within a track segment
    1313- fixed bug that didn't show a preview of the currently tagged photos when the dialog was first opened
    1414- inverted the way timezones are applied (the set timezone must be substracted from the EXIF time in order to get ZULU time, not added and that's also conform with what the setOffset dialog returns)