RelationEditor#registerRelationEditor not used?

[michael2402]

When trying to register an extended relation editor for the PT assistant plugin, we noticed that the methods to register new relation editors seem not to be functional.

There are several issues with it:

• The registerRelationEditor is not static - it probably should be
• The type of the parameter should be Class<? extends RelationEditor>. Otherwise, you can only register exact relation editor instances.
• We are not checking the full constructor signature of that class, we cannot do this since the second argument is contains a generic type info.

Is it used? If not, we should drop it and replace it by a more robust registration mechanism that does not rely on unchecked reflective accesses and uses a factory interface instead.

Alternative: Prevent the relation editor from being replaced and only allow hooks to hook into it's lifecycle so that e.g. buttons may be added by plugins.

@stoecker: You seem to have added the code, what was it used for?