Changes between Version 1 and Version 2 of Ticket #15709, comment 53


Ignore:
Timestamp:
2018-01-02T05:46:02+01:00 (4 months ago)
Author:
cmuelle8
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15709, comment 53

    v1 v2  
    2020
    2121EDIT: The LayerListDialog creates its instance in a separate static method as well, there must be a reason to do so.  Prior to r13264 ImageViewerDialog used that same creation pattern.  I'm rather curious, why r13264 truely makes a difference and exhibits unexpected behavior when combined with an enabled [https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust photoadjust plugin].
     22
     23EDIT2: The photoadjust plugin calls ImageViewerDialog.getInstance() earlier than built-in GeoImageLayer.java does, but it probably should not get a valid instance before GeoImageLayer had a chance to do addToggleDialog() for the instance (at least, prior to r13264 it did get the AssertionError until after GeoImageLayer.java (!) specifically created the instance).  So r13264 changed creation time and creator of the ImageViewerDialog instance.