Changes between Initial Version and Version 1 of Ticket #15709, comment 48


Ignore:
Timestamp:
2018-01-02T00:43:36+01:00 (8 years ago)
Author:
cmuelle8

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15709, comment 48

    initial v1  
    33
    44no hard feelings, we still found a bug, after all :)
     5
     6
     7Before r13191 {{{img}}} was not reassigned, {{{ImageDisplay.this.image = rot;}}} was used right away in this code block.
     8
     9I changed this to achieve more atomicity in the rotating case, and to use a single assignment to {{{ImageDisplay.this.image}}} only, but overlooked that the MediaTracker would cling on to a ref, if it did not receive a removeImage() instruction.
     10
     11The reason to reassigning {{{img}}} is just imho:  If there ever is a need to do more post-processing to {{{img}}} in the future, we now have the modularity to plug in a code section in between the rotating code and the finalizing assignment to {{{ImageDisplay.this.image}}} in this method.