Changes between Initial Version and Version 1 of Ticket #15233


Ignore:
Timestamp:
2017-09-03T19:45:53+02:00 (7 years ago)
Author:
sebastic
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15233 – Description

    initial v1  
    1 The recent Java 9 change (SVN r12713) to the josm launchers introduced a bashism, the test only works when bash is configured as `/bin/sh`.
     1The recent Java 9 change (SVN r12713) to the josm launchers introduced a [https://wiki.ubuntu.com/DashAsBinSh bashism], the test only works when bash is configured as `/bin/sh`:
     2{{{
     3$ checkbashisms linux/*/usr/bin/josm*
     4possible bashism in linux/latest/usr/bin/josm-latest line 49 (alternative test command ([[ foo ]] should be [ foo ])):
     5    if [[ $JAVACMD == *"java-9"* ]]; then
     6possible bashism in linux/latest/usr/bin/josm-latest line 49 (should be 'b = a'):
     7    if [[ $JAVACMD == *"java-9"* ]]; then
     8possible bashism in linux/tested/usr/bin/josm line 49 (alternative test command ([[ foo ]] should be [ foo ])):
     9    if [[ $JAVACMD == *"java-9"* ]]; then
     10possible bashism in linux/tested/usr/bin/josm line 49 (should be 'b = a'):
     11    if [[ $JAVACMD == *"java-9"* ]]; then
     12}}}
    213
    314The attached patch changes the test to use `expr(1)` which should be portable to all shells.