Items in advanced settings displayed with yellow color, despite they values set to defaults

[openstreetmap.org-user-d1g]

steps for testing are in message 6, without non-core plugins.

Applies to: 10025, 10029
Windows 7/10, regardless of Java version I guess

[openstreetmap.org-user-d1g]

This bug persists even after you uninstall relevant pluing:

(with OH plug-in deinstalled):
ohe.clocksystem=TWELVE_HOURS (displayed as yellow)
ohe.clocksystem=TWELVE_HOURS (use reset button, displayed as green with thin text)
(reopen ADS):
ohe.clocksystem=TWELVE_HOURS (displayed as yellow)

Why?..

[bastiK]

If you could provide a step-by-step instruction, how to reproduce this problem, that would help. (preferably starting with fresh preferences)

[openstreetmap.org-user-d1g]

Replying to bastiK:

If you could provide a step-by-step instruction, how to reproduce this problem, that would help. (preferably starting with fresh preferences)

I had no steps at the moment of reporting. Yes, I managed to 100% reproduce it:

1. java -jar josm-latest.jar --reset-preferences
2. F12 > Plugins, install opening_hours
3. add new layer, add one tag less node, edit OH using tool, SET checkbox "12 hours format" > OK > OK
4. select tag less node again, edit OH using tool, UNSET checkbox "12 hours format" > OK > OK
5. F12 > enable expert mode > search for "ohe.clocksystem"
6. select single item, reset it
7. observe that new ("TWENTYFOUR_HOURS", default) value is equal to old yellow value ("TWENTYFOUR_HOURS")

[openstreetmap.org-user-d1g]

BTW, ohe.clocksystem=TWENTYFOUR_HOURS property survives --reset-preferences switch...

Help/Preferences#Windows
I removed %APPDATA%\JOSM folder, but this key ohe.clocksystem is still persists?.. ​I cannot see this key in core core.

I also removed \Users\USERNAME\Application Data\JOSM folder, I tried 1-7 steps - same issue. I tried only 1,2,3,5,6,5,6,7 same issue.

[openstreetmap.org-user-d1g]

Replying to bastiK:

If you could provide a step-by-step instruction, how to reproduce this problem, that would help. (preferably starting with fresh preferences)

I tried 10029 on another PC, where JOSM was never installed. Win 10 / Java 1.7.0_80

I repeated (without reset first) 2,4,5,6,7 with following differences: default value was "TWELVE_HOURS". I.e. you can get this bug, but checkbox in dialogue will be checked by default (TWELVE_HOURS).

At second run, --reset-preferences won't erase ohe.clocksystem, then repeat a bug using 1,2,4,5,6,7 without JOSM restart.

[openstreetmap.org-user-d1g]

Again, more simple steps to reproduce:

1st test:

1. open JOSM
2. create new layer
3. detach "layers" toggle
4. close it (place it back)
5. F12, expert, expect "layerlist.docked" as YELLOW "true"
6. reset this value, get default "TRUE"

2nd test:
After JOSM restart, all .docked values are "true" (white)

3rd test:
After JOSM restart, repeat 1-3, restart.
Expect layers toggle as undocked.
Open expert AS, layerlist.docked is "false" (YELLOW)
Now pin it back and get a bug in next step
Open expert AS, layerlist.docked is "true" (YELLOW)

4th test:
After JOSM restart, all .docked values are "true" (white)

PS. I will take a break at bisecting version, too many steps to test for me, please create a test :-D

[openstreetmap.org-user-d1g]

1. Difficult to reproduce
2. nobody else reposted it
3. most likely affects only windows
4. minor feature

-> closing.