[patch] mapmodes did not listen to preferences change

[kolesar]

Some mapmodes cached preferences by their readPreferences() method and did not refresh them later. Some of them called this method on entering mode but it is not enough. When a user changes a setting of a tool it is usually active already. Therefore mapmodes should update their cached preferences on preference change.

I have modified MapMode to be PreferenceChangedListener. Also modified readPreferences() method in the affected mapmodes from private to protected for overriding.

Splinex plugin was also affected, attached a separate patchfile.

[bastiK]

The inactive mapmodes need not be on alert all the time. Why not register PreferenceChangedListener & fire readPreferences on enterMode and unregister on exitMode?

[kolesar]

Great idea, thanks. I will update patch soon.

[kolesar]

This action opens the relation that was closed last time. It works as an undo for closing relation editor. Similar to History / Recently closed windows / <first entry> Ctrl+Shift+T in web browsers.

I did not want to complicate existing Edit button and popping up last closed seemed to be a good trade-off. I will update this patch to remember a list of recently closed relations and shortcut will pop up first entry. This way shortcut can be pressed repeatedly, similar to browser tabs.

[Don-vip]

In 9572/josm:

fix #12417 - mapmodes did not listen to preferences change (patch by kolesar)