Split way breaks destination_sign relations

[Klumbumbus]

What steps will reproduce the problem?

1. split ​way/4471954

What is the expected result?

only the left way (the one connected to way with the role to) should be added to the ​relation/2812791

What happens instead?

both new ways are added to the relation

Please provide any additional information below. Attach a screenshot if possible.

(For turn restrictions this works fine when you split a way.)

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-12 00:59:37 +0100 (Tue, 12 Jan 2016)
Build-Date:2016-01-12 02:32:48
Revision:9417
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9417 en) Windows 7 32-Bit
Memory Usage: 344 MB / 742 MB (112 MB allocated, but free)
Java version: 1.8.0_66-b18, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre1.8.0_66\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=64859, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (31772)
- DirectDownload (31934)
- DirectUpload (31912)
- HouseNumberTaggingTool (31772)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- RoadSigns (31895)
- apache-commons (31895)
- buildings_tools (31895)
- download_along (31772)
- editgpx (31772)
- imagery_offset_db (31895)
- importvec (31772)
- log4j (31895)
- measurement (31895)
- photo_geotagging (31895)
- photoadjust (31963)
- public_transport (31895)
- reltoolbox (31895)
- reverter (31926)
- tag2link (31910)
- tageditor (31772)
- tagging-preset-tester (31895)
- terracer (31895)
- turnlanes (31772)
- turnrestrictions (31895)
- undelete (31895)
- utilsplugin2 (31895)
- wikipedia (31917)

Last errors/warnings:
- W: java.net.SocketException: Socket Closed
- E: java.net.SocketException: Socket Closed

[simon04]

In 9442/josm:

fix #12347 - Split way breaks destination_sign relations

[bartosomail@…]

Splitting a way still breaks destination_sign relations when the junction node is added to the relation with role "intersection" instead of role "sign".

[simon04]

In 9647/josm:

fix #12347 - Split way breaks destination_sign relations (with intersection role)

[rickmastfan67]

@simon04, is it possible that you can take a look @ #10808 too? Similar problem where JOSM is breaking relations for "No U-Turn restrictions".

[bartosomail@…]

The issue has reappeared, but only when the junction node has an "intersection" role. The splitting is still handled correctly only when the junction node has a "sign" role.
Tested with OSM version 10000.

[Don-vip]

regression of r9968 ? I took care to add a unit test, but maybe I missed something:

changeset/9968/josm/trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java
changeset/9968/josm/trunk/test/unit/org/openstreetmap/josm/actions/SplitWayActionTest.java

[bartosomail@…]

I just realized that what I stated about the junction role is not correct. It seems instead that the order of the relation members matters.

Example:

Split way 404154435 at the middle node: both segments will become member of relation 6058078, which is wrong.

Edit relation 6058078 and move the member with role "sign" under the member with role "intersection", save changes. Now try again to split way 404154435, and the result will be correct.

[Don-vip]

In 13065/josm:

fix #12347 - Split way breaks destination_sign relations

[Don-vip]

In 13066/josm:

see #12347 - NPE