Opened 12 years ago
Last modified 12 years ago
#10478 closed defect
Error when installing preset (chunk containing only list_entry items) — at Version 8
| Reported by: | malcolmh | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.09 |
| Component: | Core | Version: | |
| Keywords: | preset chunk xml validation | Cc: |
Description (last modified by )
Change History (9)
follow-up: 3 comment:1 by , 12 years ago
comment:2 by , 12 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | chunk xml validation added |
| Summary: | Error when installing preset → Error when installing preset (chunk containing only list_entry items) |
comment:3 by , 12 years ago
Replying to bastiK:
list_entryis normally inside acomboelement, so it is a little unusual to put a couple oflist_entrys in a chunk and not the entirecombo. We could allow this, but then the schema file would no longer be able to catch all the syntax errors in the preset xml.
used in combo and multiselection
- on one hand, it is useful but will clutter the presets file even more
- on the other hand a complete syntax check saves quite some time
As copy & paste works on all systems, I am in favour of the syntax check and excluding single "value" attribute definitions from chunk.
comment:4 by , 12 years ago
The reason that I need chunks with only "list_entry" items is that I have many different keys that share a common set of values, so I want to define these once and reference them in combos and multiselects with different keys. The "chunk" facility appears on the face of it to be a generalised macro definition entity, so it should only be the expanded source that is checked for validity in the preset context, i.e. don't check the chunks themselves, but check that all the invocations of the chunks result in valid preset structures.
comment:5 by , 12 years ago
| Milestone: | → 14.09 |
|---|
comment:7 by , 12 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The latest revision still causes the error at install time. Try installing https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT-1-preset.xml as a test case.
by , 12 years ago
| Attachment: | 10478_error.png added |
|---|
comment:8 by , 12 years ago
| Description: | modified (diff) |
|---|




list_entryis normally inside acomboelement, so it is a little unusual to put a couple oflist_entrys in a chunk and not the entirecombo. We could allow this, but then the schema file would no longer be able to catch all the syntax errors in the preset xml.