Opened 12 years ago
Closed 12 years ago
#8540 closed defect (fixed)
[Patch] Unglue relations not marking relations as modified
| Reported by: | bilbo | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin utilsplugin2 | Version: | latest |
| Keywords: | Cc: |
Description
Unglue relations was not fully fixed in #6403
When I unglue ways from relations, it will make extra way copies and update relation members, but won't mark relations as 'modified', so when I press 'upload', JOSM only tries to upload the newly created ways, but not the relations. This may lead later to very nasty conflicts and/or junk uploaded to server if more editing is done afterwards and the missing relations to be updated are unnoticed....
The patch fixes it (quick hack), though not correctly (after undo the relation is still marked as modified), so I suspect something in the core JOSM code may be a bit broken (adding the modified relation in the fillModifiedData in the plugin seems to have no effect) and a better fix may be needed.
Using JOSM 5777
Attachments (1)
Change History (5)
by , 12 years ago
| Attachment: | utilsplugin.patch added |
|---|
follow-up: 2 comment:1 by , 12 years ago
Note: the action is in utilsplugin2 plugin, see plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/UnGlueRelationAction.java
comment:2 by , 12 years ago
| Component: | Core → Plugin utilsplugin2 |
|---|
Replying to bilbo:
Note: the action is in utilsplugin2 plugin, see plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/UnGlueRelationAction.java
Then set the right component
comment:3 by , 12 years ago
| Summary: | Unglue relations not marking relations as modified → [Patch] Unglue relations not marking relations as modified |
|---|
comment:4 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in [o29391]. Thanks for the patch !
Patch for Utilsplugin2 - quick fix (sort of a hack)