Changeset 9989 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2016-03-14T01:49:27+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - Methods should not be empty

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• gpx/Extensions.java (modified) (2 diffs)
• imagery/ImageryInfo.java (modified) (2 diffs)
• osm/Node.java (modified) (1 diff)
• validation/OsmValidator.java (modified) (1 diff)
• validation/Test.java (modified) (1 diff)
• validation/TestError.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/gpx/Extensions.java

@@ -3 +3 @@
 
 import java.util.LinkedHashMap;
-import java.util.Map;
 
 /**
@@ -12 +11 @@
     private static final long serialVersionUID = 1L;
 
-    public Extensions(Map<? extends String, ? extends String> m) {
-        super(m);
-    }
-
+    /**
+     * Constructs a new {@code Extensions}.
+     */
     public Extensions() {
+        super();
     }
 }

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -232 +232 @@
          */
         public ImageryPreferenceEntry() {
+            // Do nothing
         }
 
@@ -296 +297 @@
             valid_georeference = i.isGeoreferenceValid();
             supports_epsg_4326_to_3857_conversion = i.isEpsg4326To3857Supported();
-
         }
 

trunk/src/org/openstreetmap/josm/data/osm/Node.java

@@ -319 +319 @@
     @Override
     public void updatePosition() {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -344 +344 @@
     @Override
     public void activeLayerChange(Layer oldLayer, Layer newLayer) {
+        // Do nothing
     }
 
     @Override
     public void layerAdded(Layer newLayer) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/data/validation/Test.java

@@ -227 +227 @@
 
     @Override
-    public void visit(Node n) {}
-
-    @Override
-    public void visit(Way w) {}
-
-    @Override
-    public void visit(Relation r) {}
+    public void visit(Node n) {
+        // To be overridden in subclasses
+    }
+
+    @Override
+    public void visit(Way w) {
+        // To be overridden in subclasses
+    }
+
+    @Override
+    public void visit(Relation r) {
+        // To be overridden in subclasses
+    }
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/TestError.java

@@ -366 +366 @@
     }
 
-    @Override public void primitivesAdded(PrimitivesAddedEvent event) {}
-
-    @Override public void tagsChanged(TagsChangedEvent event) {}
-
-    @Override public void nodeMoved(NodeMovedEvent event) {}
-
-    @Override public void wayNodesChanged(WayNodesChangedEvent event) {}
-
-    @Override public void relationMembersChanged(RelationMembersChangedEvent event) {}
-
-    @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {}
-
-    @Override public void dataChanged(DataChangedEvent event) {}
+    @Override public void primitivesAdded(PrimitivesAddedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void tagsChanged(TagsChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void nodeMoved(NodeMovedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void wayNodesChanged(WayNodesChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void relationMembersChanged(RelationMembersChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void dataChanged(DataChangedEvent event) {
+        // Do nothing
+    }
 
     @Override