Changeset 9989 in josm for trunk/src/org

Timestamp:

2016-03-14T01:49:27+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - Methods should not be empty

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (4 diffs)
• actions/UpdateModifiedAction.java (modified) (2 diffs)
• actions/downloadtasks/DownloadOsmChangeTask.java (modified) (1 diff)
• actions/mapmode/AddNoteAction.java (modified) (1 diff)
• actions/mapmode/ExtrudeAction.java (modified) (1 diff)
• actions/mapmode/SelectAction.java (modified) (1 diff)
• actions/search/SearchAction.java (modified) (2 diffs)
• command/DeleteCommand.java (modified) (1 diff)
• command/PurgeCommand.java (modified) (1 diff)
• command/SelectCommand.java (modified) (1 diff)
• data/gpx/Extensions.java (modified) (2 diffs)
• data/imagery/ImageryInfo.java (modified) (2 diffs)
• data/osm/Node.java (modified) (1 diff)
• data/validation/OsmValidator.java (modified) (1 diff)
• data/validation/Test.java (modified) (1 diff)
• data/validation/TestError.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -678 +678 @@
                         @Override
                         public void flush() {
+                            // Do nothing
                         }
 
                         @Override
                         public void close() {
+                            // Do nothing
                         }
                     });
@@ -1264 +1266 @@
     }
 
-    private static class WindowPositionSizeListener extends WindowAdapter implements
-    ComponentListener {
+    private static class WindowPositionSizeListener extends WindowAdapter implements ComponentListener {
         @Override
         public void windowStateChanged(WindowEvent e) {
@@ -1273 +1274 @@
         @Override
         public void componentHidden(ComponentEvent e) {
+            // Do nothing
         }
 
@@ -1287 +1289 @@
         @Override
         public void componentShown(ComponentEvent e) {
+            // Do nothing
         }
 

trunk/src/org/openstreetmap/josm/actions/UpdateModifiedAction.java

@@ -34 +34 @@
 
     // FIXME: overrides the behaviour of UpdateSelectionAction. Doesn't update
-    // the enabled state based on the current selection because
-    // it doesn't depend on it.
+    // the enabled state based on the current selection because it doesn't depend on it.
     // The action should be enabled/disabled based on whether there is a least
     // one modified object in the current dataset. Unfortunately, there is no
@@ -51 +50 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadOsmChangeTask.java

@@ -212 +212 @@
         @Override
         public void historyDataSetCleared(HistoryDataSet source) {
+            // Do nothing
         }
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java

@@ -94 +94 @@
     @Override
     public void doKeyReleased(KeyEvent e) {
+        // Do nothing
     }
 }

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -350 +350 @@
     @Override
     public void doKeyPressed(KeyEvent e) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -667 +667 @@
     @Override
     public void doKeyReleased(KeyEvent e) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -653 +653 @@
 
     public static class SearchSetting {
-        public String text = "";
-        public SearchMode mode = SearchMode.replace;
+        public String text;
+        public SearchMode mode;
         public boolean caseSensitive;
         public boolean regexSearch;
@@ -664 +664 @@
          */
         public SearchSetting() {
+            text = "";
+            mode = SearchMode.replace;
         }
 

trunk/src/org/openstreetmap/josm/command/DeleteCommand.java

@@ -154 +154 @@
 
     @Override
-    public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted,
-            Collection<OsmPrimitive> added) {
+    public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/command/PurgeCommand.java

@@ -276 +276 @@
     @Override
     public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/command/SelectCommand.java

@@ -33 +33 @@
     @Override
     public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/data/gpx/Extensions.java

@@ -3 +3 @@
 
 import java.util.LinkedHashMap;
-import java.util.Map;
 
 /**
@@ -12 +11 @@
     private static final long serialVersionUID = 1L;
 
-    public Extensions(Map<? extends String, ? extends String> m) {
-        super(m);
-    }
-
+    /**
+     * Constructs a new {@code Extensions}.
+     */
     public Extensions() {
+        super();
     }
 }

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -232 +232 @@
          */
         public ImageryPreferenceEntry() {
+            // Do nothing
         }
 
@@ -296 +297 @@
             valid_georeference = i.isGeoreferenceValid();
             supports_epsg_4326_to_3857_conversion = i.isEpsg4326To3857Supported();
-
         }
 

trunk/src/org/openstreetmap/josm/data/osm/Node.java

@@ -319 +319 @@
     @Override
     public void updatePosition() {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -344 +344 @@
     @Override
     public void activeLayerChange(Layer oldLayer, Layer newLayer) {
+        // Do nothing
     }
 
     @Override
     public void layerAdded(Layer newLayer) {
+        // Do nothing
     }
 

trunk/src/org/openstreetmap/josm/data/validation/Test.java

@@ -227 +227 @@
 
     @Override
-    public void visit(Node n) {}
-
-    @Override
-    public void visit(Way w) {}
-
-    @Override
-    public void visit(Relation r) {}
+    public void visit(Node n) {
+        // To be overridden in subclasses
+    }
+
+    @Override
+    public void visit(Way w) {
+        // To be overridden in subclasses
+    }
+
+    @Override
+    public void visit(Relation r) {
+        // To be overridden in subclasses
+    }
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/TestError.java

@@ -366 +366 @@
     }
 
-    @Override public void primitivesAdded(PrimitivesAddedEvent event) {}
-
-    @Override public void tagsChanged(TagsChangedEvent event) {}
-
-    @Override public void nodeMoved(NodeMovedEvent event) {}
-
-    @Override public void wayNodesChanged(WayNodesChangedEvent event) {}
-
-    @Override public void relationMembersChanged(RelationMembersChangedEvent event) {}
-
-    @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {}
-
-    @Override public void dataChanged(DataChangedEvent event) {}
+    @Override public void primitivesAdded(PrimitivesAddedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void tagsChanged(TagsChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void nodeMoved(NodeMovedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void wayNodesChanged(WayNodesChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void relationMembersChanged(RelationMembersChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {
+        // Do nothing
+    }
+
+    @Override public void dataChanged(DataChangedEvent event) {
+        // Do nothing
+    }
 
     @Override