Changeset 9973 in josm

Timestamp:

2016-03-12T23:58:33+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - JUnit4 tests should use @Test annotation

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• data/cache/JCSCachedTileLoaderJobTest.java (modified) (2 diffs)
• data/imagery/WMTSTileSourceTest.java (modified) (8 diffs)
• gui/conflict/pair/properties/PropertiesMergeModelTest.java (modified) (4 diffs)
• gui/preferences/PreferencesTestUtils.java (modified) (2 diffs)
• gui/preferences/advanced/AdvancedPreferenceTest.java (modified) (1 diff)
• gui/preferences/audio/AudioPreferenceTest.java (modified) (1 diff)
• gui/preferences/display/ColorPreferenceTest.java (modified) (1 diff)
• gui/preferences/display/DisplayPreferenceTest.java (modified) (1 diff)
• gui/preferences/display/DrawingPreferenceTest.java (modified) (1 diff)
• gui/preferences/display/LafPreferenceTest.java (modified) (1 diff)
• gui/preferences/display/LanguagePreferenceTest.java (modified) (1 diff)
• gui/preferences/imagery/ImageryPreferenceTest.java (modified) (1 diff)
• gui/preferences/map/BackupPreferenceTest.java (modified) (1 diff)
• gui/preferences/map/MapPaintPreferenceTest.java (modified) (1 diff)
• gui/preferences/map/MapPreferenceTest.java (modified) (1 diff)
• gui/preferences/map/TaggingPresetPreferenceTest.java (modified) (1 diff)
• gui/preferences/plugin/PluginPreferenceTest.java (modified) (1 diff)
• gui/preferences/projection/ProjectionPreferenceTest.java (modified) (1 diff)
• gui/preferences/remotecontrol/RemoteControlPreferenceTest.java (modified) (1 diff)
• gui/preferences/server/AuthenticationPreferenceTest.java (modified) (1 diff)
• gui/preferences/server/OverpassServerPreferenceTest.java (modified) (1 diff)
• gui/preferences/server/ProxyPreferenceTest.java (modified) (1 diff)
• gui/preferences/server/ServerAccessPreferenceTest.java (modified) (1 diff)
• gui/preferences/shortcut/ShortcutPreferenceTest.java (modified) (1 diff)
• gui/preferences/validator/ValidatorPreferenceTest.java (modified) (1 diff)
• gui/preferences/validator/ValidatorTestsPreferenceTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java

@@ -72 +72 @@
     @Test
     public void testStatusCodes() throws Exception {
-        testStatusCode(200);
+        doTestStatusCode(200);
         // can't test for 3xx, as httpstat.us redirects finally to 200 page
-        testStatusCode(401);
-        testStatusCode(402);
-        testStatusCode(403);
-        testStatusCode(404);
-        testStatusCode(405);
-        testStatusCode(500);
-        testStatusCode(501);
-        testStatusCode(502);
+        doTestStatusCode(401);
+        doTestStatusCode(402);
+        doTestStatusCode(403);
+        doTestStatusCode(404);
+        doTestStatusCode(405);
+        doTestStatusCode(500);
+        doTestStatusCode(501);
+        doTestStatusCode(502);
     }
 
     @Test
-    public void testUnkownHost() throws Exception {
+    public void testUnknownHost() throws Exception {
         TestCachedTileLoaderJob job = new TestCachedTileLoaderJob("http://unkownhost.unkownhost/unkown");
         Listener listener = new Listener();
@@ -97 +97 @@
     }
 
-    public void testStatusCode(int responseCode) throws Exception {
+    private void doTestStatusCode(int responseCode) throws Exception {
         TestCachedTileLoaderJob job = getStatusLoaderJob(responseCode);
         Listener listener = new Listener();

trunk/test/unit/org/openstreetmap/josm/data/imagery/WMTSTileSourceTest.java

@@ -10 +10 @@
 
 import org.junit.BeforeClass;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.openstreetmap.gui.jmapviewer.tilesources.TemplatedTMSTileSource;
@@ -84 +85 @@
         assertEquals("TileXMax", 4, testSource.getTileXMax(2));
         assertEquals("TileYMax", 4, testSource.getTileYMax(2));
-
     }
 
@@ -106 +106 @@
     }
 
-    // XXX - disable this test, needs further working
-    // @Test
+    @Test
+    @Ignore("disable this test, needs further working") // XXX
     public void testWALLONIENoMatrixDimension() throws MalformedURLException, IOException {
         Main.setProjection(Projections.getProjectionByCode("EPSG:31370"));
@@ -224 +224 @@
     }
 
-
-    // XXX: disabled as this needs user action
-    //@Test
+    @Test
+    @Ignore("disabled as this needs user action") // XXX
     public void testTwoTileSetsForOneProjection() throws Exception {
         Main.setProjection(Projections.getProjectionByCode("EPSG:3857"));
@@ -236 +235 @@
     }
 
-    // XXX: disabled as this needs user action
-    // @Test
+    @Test
+    @Ignore("disabled as this needs user action") // XXX
     public void testManyLayersScrollbars() throws Exception {
         Main.setProjection(Projections.getProjectionByCode("EPSG:3857"));
@@ -246 +245 @@
 
     @Test
-    public void testPraserForDuplicateTags() throws Exception {
+    public void testParserForDuplicateTags() throws Exception {
         Main.setProjection(Projections.getProjectionByCode("EPSG:3857"));
         WMTSTileSource testSource = new WMTSTileSource(testDuplicateTags);
@@ -258 +257 @@
 
     @Test
-    public void testPraserForMissingStyleIdentifier() throws Exception {
+    public void testParserForMissingStyleIdentifier() throws Exception {
         Main.setProjection(Projections.getProjectionByCode("EPSG:3857"));
         WMTSTileSource testSource = new WMTSTileSource(testMissingStyleIdentifer);
@@ -268 +267 @@
         assertEquals("Latitude", expected.lat(), ll.lat(), 1e-05);
         assertEquals("Longitude", expected.lon(), ll.lon(), 1e-05);
-
     }
 

trunk/test/unit/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMergeModelTest.java

@@ -24 +24 @@
 public class PropertiesMergeModelTest {
 
-    public abstract static class TestObserver implements Observer {
+    private abstract static class TestObserver implements Observer {
         public int numInvocations;
 
+        @Override
         public void update(Observable o, Object arg) {
             numInvocations++;
-            test();
+            doTest();
         }
 
-        public abstract void test();
+        public abstract void doTest();
 
         public void assertNumInvocations(int count) {
@@ -100 +101 @@
         assertTrue(model.hasCoordConflict());
 
-
         n1.cloneFrom(new Node(1));
         n2.setCoor(new LatLon(2, 2));
@@ -117 +117 @@
                 observerTest = new TestObserver() {
                     @Override
-                    public void test() {
+                    public void doTest() {
                         assertTrue(model.isCoordMergeDecision(MergeDecisionType.KEEP_MINE));
                     }
@@ -132 +132 @@
                 observerTest = new TestObserver() {
                     @Override
-                    public void test() {
+                    public void doTest() {
                         assertTrue(model.isCoordMergeDecision(MergeDecisionType.KEEP_THEIR));
                     }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/PreferencesTestUtils.java

@@ -18 +18 @@
      * @param parentClass optional parent setting, can be {@code null}
      */
-    public static void testPreferenceSettingAddGui(PreferenceSettingFactory factory, Class<? extends DefaultTabPreferenceSetting> parentClass) {
-        testPreferenceSettingAddGui(factory, parentClass, 1);
+    public static void doTestPreferenceSettingAddGui(
+            PreferenceSettingFactory factory, Class<? extends DefaultTabPreferenceSetting> parentClass) {
+        doTestPreferenceSettingAddGui(factory, parentClass, 1);
     }
 
@@ -28 +29 @@
      * @param increment expected tab number increment
      */
-    public static void testPreferenceSettingAddGui(PreferenceSettingFactory factory, Class<? extends DefaultTabPreferenceSetting> parentClass,
-            int increment) {
+    public static void doTestPreferenceSettingAddGui(
+            PreferenceSettingFactory factory, Class<? extends DefaultTabPreferenceSetting> parentClass, int increment) {
         PreferenceSetting setting = factory.createPreferenceSetting();
         PreferenceTabbedPane tabPane = new PreferenceTabbedPane();

trunk/test/unit/org/openstreetmap/josm/gui/preferences/advanced/AdvancedPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new AdvancedPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new AdvancedPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/audio/AudioPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new AudioPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new AudioPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/display/ColorPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ColorPreference.Factory(), DisplayPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ColorPreference.Factory(), DisplayPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/display/DisplayPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new DisplayPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new DisplayPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/display/DrawingPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new DrawingPreference.Factory(), DisplayPreference.class, 2);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new DrawingPreference.Factory(), DisplayPreference.class, 2);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/display/LafPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new LafPreference.Factory(), DisplayPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new LafPreference.Factory(), DisplayPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/display/LanguagePreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new LanguagePreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new LanguagePreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ImageryPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ImageryPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/BackupPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new BackupPreference.Factory(), MapPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new BackupPreference.Factory(), MapPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/MapPaintPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new MapPaintPreference.Factory(), MapPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new MapPaintPreference.Factory(), MapPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/MapPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new MapPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new MapPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/TaggingPresetPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new TaggingPresetPreference.Factory(), MapPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new TaggingPresetPreference.Factory(), MapPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/plugin/PluginPreferenceTest.java

@@ -89 +89 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new PluginPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new PluginPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreferenceTest.java

@@ -36 +36 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ProjectionPreference.Factory(), MapPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ProjectionPreference.Factory(), MapPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/remotecontrol/RemoteControlPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new RemoteControlPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new RemoteControlPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/server/AuthenticationPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new AuthenticationPreference.Factory(), ServerAccessPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new AuthenticationPreference.Factory(), ServerAccessPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/server/OverpassServerPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new OverpassServerPreference.Factory(), ServerAccessPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new OverpassServerPreference.Factory(), ServerAccessPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/server/ProxyPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ProxyPreference.Factory(), ServerAccessPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ProxyPreference.Factory(), ServerAccessPreference.class);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/server/ServerAccessPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ServerAccessPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ServerAccessPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/shortcut/ShortcutPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ShortcutPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ShortcutPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/validator/ValidatorPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ValidatorPreference.Factory(), null);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ValidatorPreference.Factory(), null);
     }
 }

trunk/test/unit/org/openstreetmap/josm/gui/preferences/validator/ValidatorTestsPreferenceTest.java

@@ -35 +35 @@
     @Test
     public void testAddGui() {
-        PreferencesTestUtils.testPreferenceSettingAddGui(new ValidatorTestsPreference.Factory(), ValidatorPreference.class);
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new ValidatorTestsPreference.Factory(), ValidatorPreference.class);
     }
 }