Changeset 9969 in josm

Timestamp:

2016-03-12T19:32:42+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - Avoid appending characters as strings in StringBuffer.append + add unit test

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/osm/TagMap.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/datatransfer/PrimitiveTransferable.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/datatransfer/RelationMemberTransferable.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/osm/TagMapTest.java (added)

trunk/src/org/openstreetmap/josm/data/osm/TagMap.java

@@ -234 +234 @@
         for (java.util.Map.Entry<String, String> e : entrySet()) {
             if (!first) {
-                stringBuilder.append(",");
+                stringBuilder.append(',');
             }
             stringBuilder.append(e.getKey());
-            stringBuilder.append("=");
+            stringBuilder.append('=');
             stringBuilder.append(e.getValue());
             first = false;
         }
-        stringBuilder.append("]");
+        stringBuilder.append(']');
         return stringBuilder.toString();
     }

trunk/src/org/openstreetmap/josm/gui/datatransfer/PrimitiveTransferable.java

@@ -78 +78 @@
         final StringBuilder sb = new StringBuilder();
         for (OsmPrimitive primitive : primitives) {
-            sb.append(primitive.getType());
-            sb.append(" ").append(primitive.getUniqueId());
-            sb.append(" # ").append(primitive.getDisplayName(DefaultNameFormatter.getInstance()));
-            sb.append("\n");
+            sb.append(primitive.getType())
+              .append(' ').append(primitive.getUniqueId())
+              .append(" # ").append(primitive.getDisplayName(DefaultNameFormatter.getInstance()))
+              .append('\n');
         }
         return sb.toString().replace("\u200E", "").replace("\u200F", "");

trunk/src/org/openstreetmap/josm/gui/datatransfer/RelationMemberTransferable.java

@@ -78 +78 @@
         final StringBuilder sb = new StringBuilder();
         for (RelationMember member : members) {
-            sb.append(member.getType());
-            sb.append(" ").append(member.getUniqueId());
-            sb.append(" ").append(member.getRole());
-            sb.append(" # ").append(member.getMember().getDisplayName(DefaultNameFormatter.getInstance()));
-            sb.append("\n");
+            sb.append(member.getType())
+              .append(' ').append(member.getUniqueId())
+              .append(' ').append(member.getRole())
+              .append(" # ").append(member.getMember().getDisplayName(DefaultNameFormatter.getInstance()))
+              .append('\n');
         }
         return sb.toString().replace("\u200E", "").replace("\u200F", "");

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -1401 +1401 @@
             String token = new StringBuilder(t).append(val).toString();
             if (consideredTokens.add(token)) {
-                s.append(sep).append('(').append(t).append(SearchCompiler.buildSearchStringForTag(key, val)).append(")");
+                s.append(sep).append('(').append(t).append(SearchCompiler.buildSearchStringForTag(key, val)).append(')');
                 sep = " OR ";
             }