Changeset 9942 in josm for trunk

Timestamp:

2016-03-06T22:42:46+01:00 (9 years ago)

Author:

Don-vip

Message:

fix problems seen in unit tests when launched manually from Eclipse

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/gui/JosmUserIdentityManagerTest.groovy (modified) (9 diffs)
• test/unit/org/openstreetmap/josm/io/session/SessionReaderTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -710 +710 @@
     @Override
     public void dataChanged(DataChangedEvent event) {
+        if (history == null)
+            return;
         OsmPrimitive primitive = event.getDataset().getPrimitiveById(history.getId(), history.getType());
         HistoryOsmPrimitive latest;

trunk/test/unit/org/openstreetmap/josm/gui/JosmUserIdentityManagerTest.groovy

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui
-
-import org.openstreetmap.josm.data.osm.User;
 
 import static org.junit.Assert.*
@@ -10 +8 @@
 import org.openstreetmap.josm.JOSMFixture
 import org.openstreetmap.josm.Main
+import org.openstreetmap.josm.data.osm.User
 import org.openstreetmap.josm.data.osm.UserInfo
 
@@ -39 +38 @@
 
     @Test
-    public void test_setAnonymouse() {
+    public void test_setAnonymous() {
         JosmUserIdentityManager im = JosmUserIdentityManager.getInstance()
 
@@ -120 +119 @@
 
     /**
-     * Preferences include neither an url nor a user name => we have
-     * an anonymous user
+     * Preferences include neither an url nor a user name => we have an anonymous user
      */
     @Test
@@ -140 +138 @@
 
     /**
-     * Preferences include neither an url nor a user name => we have
-     * an annoymous user
+     * Preferences include neither an url nor a user name => we have an anonymous user
      */
     @Test
@@ -154 +151 @@
         Main.pref.removePreferenceChangeListener im
 
-        Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
-        Main.pref.put "osm-server.username", null
-
-        im.initFromPreferences()
-
-        assert im.isAnonymous()
+        try {
+            Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
+            Main.pref.put "osm-server.username", null
+
+            im.initFromPreferences()
+
+            assert im.isAnonymous()
+        } finally {
+            Main.pref.addPreferenceChangeListener im
+        }
     }
 
@@ -172 +173 @@
         Main.pref.removePreferenceChangeListener im
 
-        // reset it
-        im.@userName = null
-        im.@userInfo = null
-
-        Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
-        Main.pref.put "osm-server.username", "test"
-
-        im.initFromPreferences()
-
-        assert im.isPartiallyIdentified()
+        try {
+            // reset it
+            im.@userName = null
+            im.@userInfo = null
+
+            Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
+            Main.pref.put "osm-server.username", "test"
+
+            im.initFromPreferences()
+
+            assert im.isPartiallyIdentified()
+        } finally {
+            Main.pref.addPreferenceChangeListener im
+        }
     }
 
@@ -196 +201 @@
         Main.pref.removePreferenceChangeListener im
 
-        im.setFullyIdentified "test1", new UserInfo(id: 1)
-
-        Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
-        Main.pref.put "osm-server.username", "test2"
-
-        im.initFromPreferences()
-
-        assert im.isPartiallyIdentified()
+        try {
+            im.setFullyIdentified "test1", new UserInfo(id: 1)
+
+            Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
+            Main.pref.put "osm-server.username", "test2"
+
+            im.initFromPreferences()
+
+            assert im.isPartiallyIdentified()
+        } finally {
+            Main.pref.addPreferenceChangeListener im
+        }
     }
 
@@ -218 +227 @@
         Main.pref.removePreferenceChangeListener im
 
-        im.setFullyIdentified "test1", new UserInfo(id: 1)
-
-        Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
-        Main.pref.put "osm-server.username", "test1"
-
-        im.initFromPreferences()
-
-        assert im.isFullyIdentified()
+        try {
+            im.setFullyIdentified "test1", new UserInfo(id: 1)
+
+            Main.pref.put "osm-server.url", "http://api.openstreetmap.org"
+            Main.pref.put "osm-server.username", "test1"
+
+            im.initFromPreferences()
+
+            assert im.isFullyIdentified()
+        } finally {
+            Main.pref.addPreferenceChangeListener im
+        }
     }
 

trunk/test/unit/org/openstreetmap/josm/io/session/SessionReaderTest.java

@@ -14 +14 @@
 import org.junit.Test;
 import org.openstreetmap.josm.JOSMFixture;
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.gui.layer.GpxLayer;
@@ -138 +139 @@
     @Test
     public void testReadNotes() throws IOException, IllegalDataException {
+        if (Main.isDisplayingMapView()) {
+            for (NoteLayer nl : Main.map.mapView.getLayersOfType(NoteLayer.class)) {
+                Main.map.mapView.removeLayer(nl);
+            }
+        }
         final List<Layer> layers = testRead("notes.joz");
         assertSame(layers.size(), 1);