Changeset 9929 in josm

Timestamp:

2016-03-05T15:29:39+01:00 (8 years ago)

Author:

Don-vip

Message:

findbugs

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/OsmPrimitiveComparator.java (modified) (2 diffs)
• data/validation/Severity.java (modified) (1 diff)
• gui/mappaint/mapcss/ExpressionFactory.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitiveComparator.java

@@ -5 +5 @@
 import java.util.Comparator;
 import java.util.HashMap;
-import java.util.Map;
 
 import org.openstreetmap.josm.gui.DefaultNameFormatter;
@@ -20 +19 @@
     private static final long serialVersionUID = 1L;
 
-    private final Map<OsmPrimitive, String> cache = new HashMap<>();
+    private final HashMap<OsmPrimitive, String> cache = new HashMap<>();
     private final boolean relationsFirst;
     private final boolean quick;

trunk/src/org/openstreetmap/josm/data/validation/Severity.java

@@ -41 +41 @@
 
     public static void getColors() {
-        for (Severity c:values()) {
-            c.getColor();
+        for (Severity c : values()) {
+            if (Main.isDebugEnabled()) {
+                Main.debug(c.toString());
+            }
         }
     }

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java

@@ -1137 +1137 @@
             });
             final Collection<Float> nonNullList = Utils.filter(floats, Predicates.not(Predicates.isNull()));
-            return nonNullList.isEmpty() ? Float.NaN : computeMax ? Collections.max(nonNullList) : Collections.min(nonNullList);
+            return nonNullList.isEmpty() ? (Float) Float.NaN : computeMax ? Collections.max(nonNullList) : Collections.min(nonNullList);
         }