Changeset 9917 in josm

Timestamp:

2016-03-03T23:06:36+01:00 (9 years ago)

Author:

Don-vip

Message:

better handling of HelpAwareOptionPane.showOptionDialog in headless mode

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/AbstractInfoAction.java (modified) (2 diffs)
• actions/SimplifyWayAction.java (modified) (2 diffs)
• gui/HelpAwareOptionPane.java (modified) (3 diffs)
• gui/io/AbstractUploadTask.java (modified) (1 diff)
• gui/layer/gpx/DownloadAlongPanel.java (modified) (2 diffs)
• gui/oauth/AdvancedOAuthPropertiesPanel.java (modified) (2 diffs)
• plugins/PluginHandler.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/AbstractInfoAction.java

@@ -85 +85 @@
                 )
         };
-        int ret = HelpAwareOptionPane.showOptionDialog(
+        return 0 == HelpAwareOptionPane.showOptionDialog(
                 Main.parent,
                 msg,
@@ -95 +95 @@
                 HelpUtil.ht("/WarningMessages#ToManyBrowsersToOpen")
         );
-        return ret == 0;
     }
 

trunk/src/org/openstreetmap/josm/actions/SimplifyWayAction.java

@@ -78 +78 @@
                                 )
         };
-        int ret = HelpAwareOptionPane.showOptionDialog(
+        return 0 == HelpAwareOptionPane.showOptionDialog(
                 Main.parent,
                 tr(
@@ -91 +91 @@
                         HelpUtil.ht("/Action/SimplifyWay#ConfirmSimplifyAll")
                 );
-        return ret == 0;
     }
 

trunk/src/org/openstreetmap/josm/gui/HelpAwareOptionPane.java

@@ -6 +6 @@
 import java.awt.Component;
 import java.awt.Dialog.ModalityType;
+import java.awt.GraphicsEnvironment;
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
@@ -241 +242 @@
         );
 
+        if (!GraphicsEnvironment.isHeadless()) {
+            doShowOptionDialog(parentComponent, title, options, defaultOption, helpTopic, buttons, pane);
+        }
+        return (Integer) pane.getValue();
+    }
+
+    private static void doShowOptionDialog(Component parentComponent, String title, final ButtonSpec[] options,
+            final ButtonSpec defaultOption, final String helpTopic, final List<JButton> buttons,
+            final JOptionPane pane) {
         final JDialog dialog = new JDialog(
                 JOptionPane.getFrameForComponent(parentComponent),
@@ -302 +312 @@
         }
         dialog.setVisible(true);
-        return (Integer) pane.getValue();
     }
 

trunk/src/org/openstreetmap/josm/gui/io/AbstractUploadTask.java

@@ -243 +243 @@
                 options[0],
                 "/Action/Upload#NodeStillInUseInWay"
-);
+        );
         if (ret == 0) {
             DownloadReferrersAction.downloadReferrers(Main.main.getEditLayer(), Arrays.asList(conflict.a));

trunk/src/org/openstreetmap/josm/gui/layer/gpx/DownloadAlongPanel.java

@@ -5 +5 @@
 
 import java.awt.Dimension;
-import java.awt.GraphicsEnvironment;
 import java.awt.GridBagLayout;
 
@@ -186 +185 @@
         });
 
-        int ret = 0;
-        if (!GraphicsEnvironment.isHeadless()) {
-            ret = HelpAwareOptionPane.showOptionDialog(Main.parent, this, title,
+        int ret = HelpAwareOptionPane.showOptionDialog(Main.parent, this, title,
                     JOptionPane.QUESTION_MESSAGE, null, options, options[0], helpTopic);
-        }
         if (0 == ret) {
             rememberSettings();

trunk/src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java

@@ -171 +171 @@
                 )
         };
-        int ret = HelpAwareOptionPane.showOptionDialog(
+        return 0 == HelpAwareOptionPane.showOptionDialog(
                 this,
                 tr(
@@ -184 +184 @@
                 HelpUtil.ht("/Dialog/OAuthAuthorisationWizard")
         );
-
-        return ret == 0; // OK button clicked
     }
 

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -8 +8 @@
 import java.awt.Component;
 import java.awt.Font;
-import java.awt.GraphicsEnvironment;
 import java.awt.GridBagConstraints;
 import java.awt.GridBagLayout;
@@ -856 +855 @@
                 plugins.size()))
           .append("</html>");
-        if (!GraphicsEnvironment.isHeadless()) {
-            HelpAwareOptionPane.showOptionDialog(
-                    parent,
-                    sb.toString(),
-                    tr("Warning"),
-                    JOptionPane.WARNING_MESSAGE,
-                    HelpUtil.ht("/Plugin/Loading#MissingPluginInfos")
-            );
-        }
+        HelpAwareOptionPane.showOptionDialog(
+                parent,
+                sb.toString(),
+                tr("Warning"),
+                JOptionPane.WARNING_MESSAGE,
+                HelpUtil.ht("/Plugin/Loading#MissingPluginInfos")
+        );
     }
 
@@ -1109 +1106 @@
                 )
         };
-        int ret = -1;
-        if (!GraphicsEnvironment.isHeadless()) {
-            ret = HelpAwareOptionPane.showOptionDialog(
+        return 0 == HelpAwareOptionPane.showOptionDialog(
                     parent,
                     reason,
@@ -1121 +1116 @@
                     null // FIXME: add help topic
             );
-        }
-        return ret == 0;
     }