Changeset 9877 in josm for trunk

Timestamp:

2016-02-24T22:48:05+01:00 (8 years ago)

Author:

simon04

Message:

fix #12488 - Fix ArrayIndexOutOfBoundsException when using tag filter in properties dialog

Location:

trunk/src/org/openstreetmap/josm/gui/dialogs/properties

Files:

• PropertiesDialog.java (modified) (3 diffs)
• TagEditHelper.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -45 +45 @@
 import javax.swing.event.ListSelectionEvent;
 import javax.swing.event.ListSelectionListener;
+import javax.swing.event.RowSorterEvent;
+import javax.swing.event.RowSorterListener;
 import javax.swing.table.DefaultTableCellRenderer;
 import javax.swing.table.DefaultTableModel;
@@ -309 +311 @@
         tagTable.setRowSorter(tagRowSorter);
 
+        final RemoveHiddenSelection removeHiddenSelection = new RemoveHiddenSelection();
+        tagTable.getSelectionModel().addListSelectionListener(removeHiddenSelection);
+        tagTable.getRowSorter().addRowSorterListener(removeHiddenSelection);
+
         tagRowSorter.setComparator(0, AlphanumComparator.getInstance());
         tagRowSorter.setComparator(1, new Comparator<Object>() {
@@ -1417 +1423 @@
         }
     }
+
+    /**
+     * Clears the row selection when it is filtered away by the row sorter.
+     */
+    private class RemoveHiddenSelection implements ListSelectionListener, RowSorterListener {
+
+        void removeHiddenSelection() {
+            try {
+                tagTable.getRowSorter().convertRowIndexToModel(tagTable.getSelectedRow());
+            } catch (IndexOutOfBoundsException ignore) {
+                Main.debug("Clearing tagTable selection, {0}", ignore.toString());
+                tagTable.clearSelection();
+            }
+        }
+
+        @Override
+        public void valueChanged(ListSelectionEvent event) {
+            removeHiddenSelection();
+        }
+
+        @Override
+        public void sorterChanged(RowSorterEvent e) {
+            removeHiddenSelection();
+        }
+    }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -668 +668 @@
                 }
                 for (int i = 0; i < tagData.getRowCount(); ++i) {
-                    if (item.getValue().equals(getDataKey(i))) {
+                    if (item.getValue().equals(tagData.getValueAt(i, 0) /* sic! do not use getDataKey*/)) {
                         if (itemToSelect == item) {
                             itemToSelect = null;