Changeset 9833 in josm

Timestamp:

2016-02-19T16:26:48+01:00 (8 years ago)

Author:

bastiK

Message:

fixed #12507 - slow mouse wheel scrolling (based on patch by kolesar)

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• ExtendedDialog.java (modified) (1 diff)
• dialogs/MapPaintDialog.java (modified) (1 diff)
• dialogs/ToggleDialog.java (modified) (3 diffs)
• dialogs/properties/PropertiesDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/ExtendedDialog.java

@@ -392 +392 @@
         if (placeContentInScrollPane) {
             JScrollPane pane = new JScrollPane(cp);
+            GuiHelper.setDefaultIncrement(pane);
             pane.setBorder(null);
             setContentPane(pane);

trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java

@@ -175 +175 @@
         InputMapUtils.addSpacebarAction(tblStyles, onoffAction);
 
-        JScrollPane sp = new JScrollPane(p);
-        GuiHelper.setDefaultIncrement(sp);
-        createLayout(sp, false, Arrays.asList(
+        createLayout(p, true, Arrays.asList(
                 new SideButton(onoffAction, false),
                 new SideButton(upAction, false),

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -46 +46 @@
 import javax.swing.JScrollPane;
 import javax.swing.JToggleButton;
+import javax.swing.Scrollable;
 import javax.swing.SwingUtilities;
 
@@ -64 +65 @@
 import org.openstreetmap.josm.gui.preferences.SubPreferenceSetting;
 import org.openstreetmap.josm.gui.preferences.TabPreferenceSetting;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.gui.widgets.PopupMenuLauncher;
 import org.openstreetmap.josm.tools.Destroyable;
@@ -874 +876 @@
             Collection<SideButton>... nextButtons) {
         if (scroll) {
-            data = new JScrollPane(data);
+            JScrollPane sp = new JScrollPane(data);
+            if (!(data instanceof Scrollable)) {
+                GuiHelper.setDefaultIncrement(sp);
+            }
+            data = sp;
         }
         LinkedList<Collection<SideButton>> buttons = new LinkedList<>();

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -293 +293 @@
         selectSth.setPreferredSize(scrollPane.getSize());
         presets.setSize(scrollPane.getSize());
-        GuiHelper.setDefaultIncrement(scrollPane);
 
         editHelper.loadTagsIfNeeded();