Changeset 9711 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2016-02-01T23:47:27+01:00 (8 years ago)

Author:

simon04

Message:

see #12300 - Provide wrapper classes for transfer data to avoid unchecked casts

Location:

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer

Files:

• PrimitiveTransferableTest.java (modified) (2 diffs)
• RelationMemberTransferableTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer/PrimitiveTransferableTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.openstreetmap.josm.gui.datatransfer.PrimitiveTransferable.PRIMITIVE_DATA;
@@ -57 +56 @@
      */
     @Test
-    @SuppressWarnings("unchecked")
     public void testGetTransferDataNominal() throws UnsupportedFlavorException {
         PrimitiveTransferable pt = new PrimitiveTransferable(Collections.singleton(new Node(1)));
         assertEquals("node 1 # incomplete\n", pt.getTransferData(DataFlavor.stringFlavor));
-        Collection<PrimitiveData> td = (Collection<PrimitiveData>) pt.getTransferData(PRIMITIVE_DATA);
+        Collection<PrimitiveData> td = ((PrimitiveTransferable.Data) pt.getTransferData(PRIMITIVE_DATA)).getPrimitiveData();
         assertEquals(1, td.size());
-        assertNotNull(td.iterator().next());
+        assertTrue(td.iterator().next() instanceof PrimitiveData);
     }
 

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer/RelationMemberTransferableTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.openstreetmap.josm.gui.datatransfer.RelationMemberTransferable.RELATION_MEMBER_DATA;
@@ -17 +16 @@
 import org.openstreetmap.josm.JOSMFixture;
 import org.openstreetmap.josm.data.osm.Node;
-import org.openstreetmap.josm.data.osm.PrimitiveData;
 import org.openstreetmap.josm.data.osm.RelationMember;
+import org.openstreetmap.josm.data.osm.RelationMemberData;
 
 /**
@@ -58 +57 @@
      */
     @Test
-    @SuppressWarnings("unchecked")
     public void testGetTransferDataNominal() throws UnsupportedFlavorException {
         RelationMemberTransferable rmt = new RelationMemberTransferable(Collections.singleton(new RelationMember("test", new Node(1))));
         assertEquals("node 1 test # incomplete\n", rmt.getTransferData(DataFlavor.stringFlavor));
-        Collection<PrimitiveData> td = (Collection<PrimitiveData>) rmt.getTransferData(RELATION_MEMBER_DATA);
+        Collection<RelationMemberData> td = ((RelationMemberTransferable.Data) rmt.getTransferData(RELATION_MEMBER_DATA)).getRelationMemberData();
         assertEquals(1, td.size());
-        assertNotNull(td.iterator().next());
+        assertTrue(td.iterator().next() instanceof RelationMemberData);
     }