Changeset 9703 in josm for trunk/src

Timestamp:

2016-02-01T10:47:51+01:00 (8 years ago)

Author:

simon04

Message:

see #12472 - Fix warnings identified by error-prone

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/Storage.java (modified) (1 diff)
• gui/SideButton.java (modified) (1 diff)
• io/NmeaReader.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/Storage.java

@@ -412 +412 @@
         @Override
         public T remove(Object o) {
-            modCount++;
-            @SuppressWarnings("unchecked") K key = (K) o;
-            int bucket = getBucket(fHash, key);
-
-            return bucket < 0 ? null : doRemove(bucket);
+            synchronized (Storage.this) {
+                modCount++;
+                @SuppressWarnings("unchecked") K key = (K) o;
+                int bucket = getBucket(fHash, key);
+
+                return bucket < 0 ? null : doRemove(bucket);
+            }
         }
 

trunk/src/org/openstreetmap/josm/gui/SideButton.java

@@ -57 +57 @@
                 @Override
                 public void propertyChange(PropertyChangeEvent evt) {
-                    if (evt.getPropertyName() == javax.swing.Action.SMALL_ICON) {
+                    if (javax.swing.Action.SMALL_ICON.equals(evt.getPropertyName())) {
                         fixIcon(null);
                     }

trunk/src/org/openstreetmap/josm/io/NmeaReader.java

@@ -50 +50 @@
         public String getType() {
             return this.type;
-        }
-
-        public boolean equals(String type) {
-            return this.type.equals(type);
         }
     }