Changeset 9671 in josm for trunk/test/unit

Timestamp:

2016-01-29T19:36:59+01:00 (8 years ago)

Author:

Don-vip

Message:

fix/cleanup unit tests

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• actions/PurgeActionTest.java (modified) (1 diff)
• command/conflict/ConflictAddCommandTest.java (modified) (3 diffs)
• command/conflict/CoordinateConflictResolveCommandTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/PurgeActionTest.java

@@ -43 +43 @@
         try (InputStream is = TestUtils.getRegressionDataStream(12038, "data.osm")) {
             DataSet ds = OsmReader.parseDataSet(is, null);
-            Main.map.mapView.addLayer(new OsmDataLayer(ds, null, null));
-            for (Way w : ds.getWays()) {
-                if (w.getId() == 222191929L) {
-                    ds.addSelected(w);
+            OsmDataLayer layer = new OsmDataLayer(ds, null, null);
+            Main.main.addLayer(layer);
+            try {
+                for (Way w : ds.getWays()) {
+                    if (w.getId() == 222191929L) {
+                        ds.addSelected(w);
+                    }
                 }
-            }
-            new PurgeAction().actionPerformed(null);
-            for (Way w : ds.getWays()) {
-                if (w.getId() == 222191929L) {
-                    assertTrue(w.isIncomplete());
-                    assertEquals(0, w.getNodesCount());
+                new PurgeAction().actionPerformed(null);
+                for (Way w : ds.getWays()) {
+                    if (w.getId() == 222191929L) {
+                        assertTrue(w.isIncomplete());
+                        assertEquals(0, w.getNodesCount());
+                    }
                 }
+            } finally {
+                // Ensure we clean the place before leaving, even if test fails.
+                Main.main.removeLayer(layer);
             }
         }

trunk/test/unit/org/openstreetmap/josm/command/conflict/ConflictAddCommandTest.java

@@ -5 +5 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
-import nl.jqno.equalsverifier.EqualsVerifier;
-import nl.jqno.equalsverifier.Warning;
 
+import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -18 +17 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
 /**
  * Unit tests of {@link ConflictAddCommand} class.
  */
 public class ConflictAddCommandTest {
+
+    private static OsmDataLayer layer;
 
     /**
@@ -29 +33 @@
     public static void setUpBeforeClass() {
         JOSMFixture.createUnitTestFixture().init(true);
-        Main.map.mapView.addLayer(new OsmDataLayer(new DataSet(), null, null));
+        layer = new OsmDataLayer(new DataSet(), null, null);
+        Main.main.addLayer(layer);
+    }
+
+    /**
+     * Cleanup test resources.
+     */
+    @AfterClass
+    public static void tearDownAfterClass() {
+        Main.main.removeLayer(layer);
     }
 

trunk/test/unit/org/openstreetmap/josm/command/conflict/CoordinateConflictResolveCommandTest.java

@@ -5 +5 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
-import nl.jqno.equalsverifier.EqualsVerifier;
-import nl.jqno.equalsverifier.Warning;
 
+import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -20 +19 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
 /**
  * Unit tests of {@link CoordinateConflictResolveCommand} class.
  */
 public class CoordinateConflictResolveCommandTest {
+
+    private static OsmDataLayer layer;
 
     /**
@@ -31 +35 @@
     public static void setUpBeforeClass() {
         JOSMFixture.createUnitTestFixture().init(true);
-        Main.map.mapView.addLayer(new OsmDataLayer(new DataSet(), null, null));
+        layer = new OsmDataLayer(new DataSet(), null, null);
+        Main.main.addLayer(layer);
+    }
+
+    /**
+     * Cleanup test resources.
+     */
+    @AfterClass
+    public static void tearDownAfterClass() {
+        Main.main.removeLayer(layer);
     }