Changeset 9634 in josm


Ignore:
Timestamp:
2016-01-26T00:20:58+01:00 (9 years ago)
Author:
Don-vip
Message:

fix findbugs/coverity issues

Location:
trunk/src/org/openstreetmap/josm
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/org/openstreetmap/josm/gui/MapStatus.java

    r9576 r9634  
    674674            // remove mouse states that are in the queue. Our mouse state is newer.
    675675            incomingMouseState.clear();
    676             incomingMouseState.offer(ms);
     676            if (!incomingMouseState.offer(ms)) {
     677                Main.warn("Unable to handle new MouseState: " + ms);
     678            }
    677679        }
    678680    }

  • trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

    r9623 r9634  
    587587    }
    588588
    589     private class ZoomData {
     589    private static class ZoomData {
    590590        private final EastNorth center;
    591591        private final double scale;

  • trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

    r9627 r9634  
    207207                }
    208208                panel.add(new JLabel("<html><body width=\"500\"><b>"+b.toString().trim()+"</b></body></html>"), GBC.eol().insets(0, 0, 0, 10));
    209                 if (!details.isEmpty()) {
     209                if (details != null && !details.isEmpty()) {
    210210                    panel.add(new JLabel(tr("Details:")), GBC.eol().insets(0, 0, 0, 10));
    211211                    JosmTextArea area = new JosmTextArea(details);

  • trunk/src/org/openstreetmap/josm/tools/MultikeyActionsHandler.java

    r9078 r9634  
    3434    private final Map<MultikeyShortcutAction, MyAction> myActions = new HashMap<>();
    3535
    36     private final class ShowLayersPopupWorker implements Runnable {
     36    private static final class ShowLayersPopupWorker implements Runnable {
    3737        private final MyAction action;
    3838
Note: See TracChangeset for help on using the changeset viewer.