Changeset 9454 in josm

Timestamp:

2016-01-15T00:26:24+01:00 (8 years ago)

Author:

Don-vip

Message:

checkstyle + add basic unit test

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/history/CoordinateInfoViewer.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java (modified) (1 diff)
• src/org/openstreetmap/josm/tools/ImageProvider.java (modified) (4 diffs)
• test/unit/org/openstreetmap/josm/gui/history (added)
• test/unit/org/openstreetmap/josm/gui/history/CoordinateInfoViewerTest.java (added)

trunk/src/org/openstreetmap/josm/gui/history/CoordinateInfoViewer.java

@@ -28 +28 @@
  * An UI widget for displaying differences in the coordinates of two
  * {@link HistoryNode}s.
- *
+ * @since 2243
  */
 public class CoordinateInfoViewer extends JPanel {
@@ -327 +327 @@
         private final Updater updater;
 
-        public MapViewer(HistoryBrowserModel model) {
+        MapViewer(HistoryBrowserModel model) {
             this.updater = new Updater(model, PointInTimeType.REFERENCE_POINT_IN_TIME);
             setBorder(BorderFactory.createLineBorder(Color.DARK_GRAY));

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -105 +105 @@
         referenceRelationMemberTableModel = new DiffTableModel();
 
-        OsmDataLayer editLayer = Main.main.getEditLayer();
-        if (editLayer != null) {
-            editLayer.data.addDataSetListener(this);
+        if (Main.main != null) {
+            OsmDataLayer editLayer = Main.main.getEditLayer();
+            if (editLayer != null) {
+                editLayer.data.addDataSetListener(this);
+            }
         }
         MapView.addLayerChangeListener(this);

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -63 +63 @@
 import org.openstreetmap.josm.gui.mappaint.StyleElementList;
 import org.openstreetmap.josm.gui.mappaint.styleelement.MapImage;
+import org.openstreetmap.josm.gui.mappaint.styleelement.NodeElement;
 import org.openstreetmap.josm.gui.mappaint.styleelement.StyleElement;
 import org.openstreetmap.josm.gui.tagging.presets.TaggingPreset;
@@ -81 +82 @@
 import com.kitfox.svg.SVGDiagram;
 import com.kitfox.svg.SVGUniverse;
-import org.openstreetmap.josm.gui.mappaint.styleelement.NodeElement;
 
 /**
@@ -1057 +1057 @@
         }
         // Try user-data directory
-        String dir = new File(Main.pref.getUserDataDirectory(), "images").getAbsolutePath();
-        try {
-            u = getImageUrl(dir, imageName, additionalClassLoaders);
-            if (u != null)
-                return u;
-        } catch (SecurityException e) {
-            Main.warn(tr(
-                    "Failed to access directory ''{0}'' for security reasons. Exception was: {1}", dir, e
-                    .toString()));
+        if (Main.pref != null) {
+            String dir = new File(Main.pref.getUserDataDirectory(), "images").getAbsolutePath();
+            try {
+                u = getImageUrl(dir, imageName, additionalClassLoaders);
+                if (u != null)
+                    return u;
+            } catch (SecurityException e) {
+                Main.warn(tr(
+                        "Failed to access directory ''{0}'' for security reasons. Exception was: {1}", dir, e
+                        .toString()));
+            }
         }
 
@@ -1079 +1081 @@
 
         // Try all other resource directories
-        for (String location : Main.pref.getAllPossiblePreferenceDirs()) {
-            u = getImageUrl(location + "images", imageName, additionalClassLoaders);
-            if (u != null)
-                return u;
-            u = getImageUrl(location, imageName, additionalClassLoaders);
-            if (u != null)
-                return u;
+        if (Main.pref != null) {
+            for (String location : Main.pref.getAllPossiblePreferenceDirs()) {
+                u = getImageUrl(location + "images", imageName, additionalClassLoaders);
+                if (u != null)
+                    return u;
+                u = getImageUrl(location, imageName, additionalClassLoaders);
+                if (u != null)
+                    return u;
+            }
         }