Changeset 9320 in josm

Timestamp:

2016-01-05T15:34:45+01:00 (9 years ago)

Author:

simon04

Message:

Refactoring (make Help a JosmAction)

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/HelpAction.java (modified) (4 diffs)
• gui/MainMenu.java (modified) (1 diff)
• gui/help/HelpUtil.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/HelpAction.java

@@ -7 +7 @@
 import java.awt.Point;
 import java.awt.event.ActionEvent;
+import java.awt.event.KeyEvent;
 
-import javax.swing.AbstractAction;
 import javax.swing.SwingUtilities;
 
@@ -15 +15 @@
 import org.openstreetmap.josm.gui.help.HelpUtil;
 import org.openstreetmap.josm.io.OnlineResource;
-import org.openstreetmap.josm.tools.ImageProvider;
+import org.openstreetmap.josm.tools.Shortcut;
 
 /**
@@ -21 +21 @@
  * @since 155
  */
-public class HelpAction extends AbstractAction {
+public class HelpAction extends JosmAction {
 
     /**
@@ -27 +27 @@
      */
     public HelpAction() {
-        super(tr("Help"));
-        new ImageProvider("help").getResource().getImageIcon(this);
-        putValue("toolbar", "help");
+        this(true);
+    }
+
+    private HelpAction(boolean shortcut) {
+        super(tr("Help"), "help", null,
+                shortcut ? Shortcut.registerShortcut("system:help", tr("Help"), KeyEvent.VK_F1, Shortcut.DIRECT) : null,
+                true);
         setEnabled(!Main.isOffline(OnlineResource.JOSM_WEBSITE));
+    }
+
+    /**
+     * Constructs a new {@code HelpAction} without assigning a shortcut.
+     * @return a new {@code HelpAction}
+     */
+    public static HelpAction createWithoutShortcut() {
+        return new HelpAction(false);
     }
 

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -818 +818 @@
         });
 
-        helpMenu.add(statusreport);
-        helpMenu.add(reportbug);
+        add(helpMenu, statusreport);
+        add(helpMenu, reportbug);
         helpMenu.addSeparator();
 
-        // FIXME why is help not a JosmAction?
-        helpMenu.add(help).setAccelerator(Shortcut.registerShortcut("system:help", tr("Help"), KeyEvent.VK_F1,
-                Shortcut.DIRECT).getKeyStroke());
+        add(helpMenu, help);
         add(helpMenu, about);
         add(Box.createHorizontalGlue());

trunk/src/org/openstreetmap/josm/gui/help/HelpUtil.java

@@ -192 +192 @@
             return Main.main.menu.help;
         }
-        return new HelpAction();
+        return HelpAction.createWithoutShortcut();
     }