Changeset 9304 in josm for trunk/src/org

Timestamp:

2016-01-04T17:23:16+01:00 (8 years ago)

Author:

simon04

Message:

fix #12237 - Preset search: JOSM remembers presets not used

Regression of r7412

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java

@@ -322 +322 @@
             @Override
             public void actionPerformed(ActionEvent ae) {
-                String res = getSelectedPreset().getToolbarString();
-                Main.toolbar.addCustomButton(res, -1, false);
+                final TaggingPreset preset = lsResult.getSelectedValue();
+                if (preset != null) {
+                    Main.toolbar.addCustomButton(preset.getToolbarString(), -1, false);
+                }
             }
         });
@@ -354 +356 @@
                 text, onlyApplicable, inTags, getTypesInSelection(), selected);
 
-        TaggingPreset oldPreset = getSelectedPreset();
+        final TaggingPreset oldPreset = lsResult.getSelectedValue();
         lsResultModel.setPresets(result);
-        TaggingPreset newPreset = getSelectedPreset();
+        final TaggingPreset newPreset = lsResult.getSelectedValue();
         if (!Objects.equals(oldPreset, newPreset)) {
             int[] indices = lsResult.getSelectedIndices();
@@ -522 +524 @@
 
     /**
-     * Determines, which preset is selected at the current moment
+     * Determines, which preset is selected at the moment. Updates {@link PresetClassification#favoriteIndex}!
      * @return selected preset (as action)
      */