Changeset 9078 in josm for trunk/src/org/openstreetmap/josm/gui/oauth

Timestamp:

2015-12-02T00:05:09+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - Immutable Field

Location:

trunk/src/org/openstreetmap/josm/gui/oauth

Files:

• RetrieveAccessTokenTask.java (modified) (1 diff)
• RetrieveRequestTokenTask.java (modified) (1 diff)
• TestAccessTokenTask.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveAccessTokenTask.java

@@ -28 +28 @@
     private boolean canceled;
     private OAuthToken accessToken;
-    private OAuthParameters parameters;
+    private final OAuthParameters parameters;
     private OsmOAuthAuthorizationClient client;
-    private OAuthToken requestToken;
-    private Component parent;
+    private final OAuthToken requestToken;
+    private final Component parent;
 
     /**

trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveRequestTokenTask.java

@@ -27 +27 @@
     private boolean canceled;
     private OAuthToken requestToken;
-    private OAuthParameters parameters;
+    private final OAuthParameters parameters;
     private OsmOAuthAuthorizationClient client;
-    private Component parent;
+    private final Component parent;
 
     /**

trunk/src/org/openstreetmap/josm/gui/oauth/TestAccessTokenTask.java

@@ -12 +12 @@
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
-
-import oauth.signpost.OAuthConsumer;
-import oauth.signpost.exception.OAuthException;
 
 import org.openstreetmap.josm.Main;
@@ -33 +30 @@
 import org.xml.sax.SAXException;
 
+import oauth.signpost.OAuthConsumer;
+import oauth.signpost.exception.OAuthException;
+
 /**
  * Checks whether an OSM API server can be accessed with a specific Access Token.
@@ -41 +41 @@
  */
 public class TestAccessTokenTask extends PleaseWaitRunnable {
-    private OAuthToken token;
-    private OAuthParameters oauthParameters;
+    private final OAuthToken token;
+    private final OAuthParameters oauthParameters;
     private boolean canceled;
-    private Component parent;
-    private String apiUrl;
+    private final Component parent;
+    private final String apiUrl;
     private HttpURLConnection connection;