Changeset 9074 in josm for trunk/src/org

Timestamp:

2015-11-30T23:30:47+01:00 (8 years ago)

Author:

Don-vip

Message:

pmd - Ternary operator with a boolean literal can be simplified with a boolean expression

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (2 diffs)
• actions/mapmode/DrawAction.java (modified) (1 diff)
• data/Preferences.java (modified) (1 diff)
• gui/HelpAwareOptionPane.java (modified) (1 diff)
• gui/dialogs/ToggleDialog.java (modified) (1 diff)
• gui/preferences/SourceEditor.java (modified) (1 diff)
• gui/widgets/MultiSplitLayout.java (modified) (1 diff)
• tools/MultiMap.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -1617 +1617 @@
      */
     public static boolean addMapFrameListener(MapFrameListener listener, boolean fireWhenMapViewPresent) {
-        boolean changed = listener != null ? mapFrameListeners.add(listener) : false;
+        boolean changed = listener != null && mapFrameListeners.add(listener);
         if (fireWhenMapViewPresent && changed && map != null) {
             listener.mapFrameInitialized(null, map);
@@ -1641 +1641 @@
      */
     public static boolean removeMapFrameListener(MapFrameListener listener) {
-        return listener != null ? mapFrameListeners.remove(listener) : false;
+        return listener != null && mapFrameListeners.remove(listener);
     }
 

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -1548 +1548 @@
                     nearestAngle = getNearestAngle(angle);
                     if (getAngleDelta(nearestAngle, angle) < snapAngleTolerance) {
-                        active = (customBaseHeading >= 0) ? true : Math.abs(nearestAngle - 180) > 1e-3;
+                        active = customBaseHeading >= 0 || Math.abs(nearestAngle - 180) > 1e-3;
                         // if angle is to previous segment, exclude 180 degrees
                         lastAngle = nearestAngle;

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -788 +788 @@
     public synchronized boolean getBoolean(final String key) {
         String s = get(key, null);
-        return s == null ? false : Boolean.parseBoolean(s);
+        return s != null && Boolean.parseBoolean(s);
     }
 

trunk/src/org/openstreetmap/josm/gui/HelpAwareOptionPane.java

@@ -102 +102 @@
 
         private boolean addChangeListener(ChangeListener listener) {
-            return listener != null ? listeners.add(listener) : false;
+            return listener != null && listeners.add(listener);
         }
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -762 +762 @@
     protected void setIsDocked(boolean val) {
         if (buttonsPanel != null) {
-            buttonsPanel.setVisible(val ? buttonHiding != ButtonHidingType.ALWAYS_HIDDEN : true);
+            buttonsPanel.setVisible(!val || buttonHiding != ButtonHidingType.ALWAYS_HIDDEN);
         }
         isDocked = val;

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

@@ -792 +792 @@
 
             if (canEnable) {
-                cbActive = new JCheckBox(tr("active"), e != null ? e.active : true);
+                cbActive = new JCheckBox(tr("active"), e == null || e.active);
                 p.add(cbActive, GBC.eol().insets(15, 0, 5, 0));
             }

trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java

@@ -1115 +1115 @@
         public final boolean isVertical() {
             Split parent = parent_get();
-            return (parent != null) ? parent.isRowLayout() : false;
+            return parent != null && parent.isRowLayout();
         }
 

trunk/src/org/openstreetmap/josm/tools/MultiMap.java

@@ -148 +148 @@
     public boolean contains(A key, B value) {
         Set<B> values = get(key);
-        return (values == null) ? false : values.contains(value);
+        return values != null && values.contains(value);
     }