Changeset 8734 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2015-09-08T15:20:34+02:00 (10 years ago)

Author:

simon04

Message:

see #11843 - Give all started threads sensible names

Utils#newThreadFactory creates a ThreadFactory to be used when
obtaining a new Executor via Executors.new….

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• cache/JCSCachedTileLoaderJob.java (modified) (1 diff)
• imagery/TMSCachedTileLoader.java (modified) (3 diffs)
• imagery/WMSCachedTileLoader.java (modified) (1 diff)
• osm/MultipolygonBuilder.java (modified) (1 diff)
• osm/visitor/paint/StyledMapRenderer.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java

@@ -77 +77 @@
             // make queue of LIFO type - so recently requested tiles will be loaded first (assuming that these are which user is waiting to see)
             new LinkedBlockingDeque<Runnable>(),
-            Utils.getNamedThreadFactory("JCS downloader")
+            Utils.newThreadFactory("JCS-downloader-%d", Thread.NORM_PRIORITY)
             );
 

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoader.java

@@ -50 +50 @@
      * and for TMS imagery
      */
-    private static ThreadPoolExecutor DEFAULT_DOWNLOAD_JOB_DISPATCHER = getNewThreadPoolExecutor("TMS downloader");
+    private static ThreadPoolExecutor DEFAULT_DOWNLOAD_JOB_DISPATCHER = getNewThreadPoolExecutor("TMS-downloader-%d");
 
 
@@ -74 +74 @@
 
     /**
-     * @param name name of the threads
+     * @param nameFormat see {@link Utils#newThreadFactory(String, int)}
      * @param workers number of worker thread to keep
      * @return new ThreadPoolExecutor that will use a @see HostLimitQueue based queue
      */
-    public static ThreadPoolExecutor getNewThreadPoolExecutor(String name, int workers) {
+    public static ThreadPoolExecutor getNewThreadPoolExecutor(String nameFormat, int workers) {
         return new ThreadPoolExecutor(
                 workers, // keep the thread number constant
@@ -85 +85 @@
                 TimeUnit.SECONDS,
                 new HostLimitQueue(HOST_LIMIT.get().intValue()),
-                Utils.getNamedThreadFactory(name)
+                Utils.newThreadFactory(nameFormat, Thread.NORM_PRIORITY)
                 );
     }

trunk/src/org/openstreetmap/josm/data/imagery/WMSCachedTileLoader.java

@@ -34 +34 @@
 
         super(listener, cache, connectTimeout, readTimeout, headers);
-        setDownloadExecutor(TMSCachedTileLoader.getNewThreadPoolExecutor("WMS downloader", THREAD_LIMIT.get()));
+        setDownloadExecutor(TMSCachedTileLoader.getNewThreadPoolExecutor("WMS-downloader-%d", THREAD_LIMIT.get()));
     }
 

trunk/src/org/openstreetmap/josm/data/osm/MultipolygonBuilder.java

@@ -32 +32 @@
 
     private static final Pair<Integer, ExecutorService> THREAD_POOL =
-            Utils.newThreadPool("multipolygon_creation.numberOfThreads");
+            Utils.newThreadPool("multipolygon_creation.numberOfThreads", "multipolygon-builder-%d", Thread.NORM_PRIORITY);
 
     /**

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -87 +87 @@
 
     private static final Pair<Integer, ExecutorService> THREAD_POOL =
-            Utils.newThreadPool("mappaint.StyledMapRenderer.style_creation.numberOfThreads");
+            Utils.newThreadPool("mappaint.StyledMapRenderer.style_creation.numberOfThreads", "styled-map-renderer-%d", Thread.NORM_PRIORITY);
 
     /**