Changeset 8658 in josm

Timestamp:

2015-08-11T23:34:03+02:00 (10 years ago)

Author:

Don-vip

Message:

fix #11756 - NPEs

Location:

trunk/src/org/openstreetmap/josm/gui/layer/geoimage

Files:

• CorrelateGpxWithImages.java (modified) (1 diff)
• GeoImageLayer.java (modified) (4 diffs)
• ShowThumbnailAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java

@@ -1096 +1096 @@
      */
     private List<ImageEntry> getSortedImgList(boolean exif, boolean tagged) {
+        if (yLayer.data == null) {
+            return Collections.emptyList();
+        }
         List<ImageEntry> dateImgLst = new ArrayList<>(yLayer.data.size());
         for (ImageEntry e : yLayer.data) {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -252 +252 @@
                 Main.main.addLayer(layer);
 
-                if (!canceled && !layer.data.isEmpty()) {
+                if (!canceled && layer.data != null && !layer.data.isEmpty()) {
                     boolean noGeotagFound = true;
                     for (ImageEntry e : layer.data) {
@@ -317 +317 @@
     public GeoImageLayer(final List<ImageEntry> data, GpxLayer gpxLayer, final String name, boolean useThumbs) {
         super(name != null ? name : tr("Geotagged Images"));
-        Collections.sort(data);
+        if (data != null) {
+            Collections.sort(data);
+        }
         this.data = data;
         this.gpxLayer = gpxLayer;
@@ -755 +757 @@
 
     public void checkPreviousNextButtons() {
-        ImageViewerDialog.setNextEnabled(currentPhoto < data.size() - 1);
+        ImageViewerDialog.setNextEnabled(data != null && currentPhoto < data.size() - 1);
         ImageViewerDialog.setPreviousEnabled(currentPhoto > 0);
     }
@@ -1087 +1089 @@
      */
     public List<ImageEntry> getImages() {
+        if (data == null) {
+            return Collections.emptyList();
+        }
         List<ImageEntry> copy = new ArrayList<>(data.size());
         for (ImageEntry ie : data) {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ShowThumbnailAction.java

@@ -51 +51 @@
      */
     private static boolean enabled(GeoImageLayer layer) {
-        return !layer.data.isEmpty();
+        return layer.data != null && !layer.data.isEmpty();
     }