Changeset 8588 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2015-07-09T23:42:02+02:00 (10 years ago)

Author:

Don-vip

Message:

fix #11657 - User.createOsmUser() memory optimization

File:

• trunk/src/org/openstreetmap/josm/data/osm/User.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/User.java

@@ -20 +20 @@
  * is only one user object.
  *
- *
+ * @since 227
  */
 public final class User {
@@ -59 +59 @@
     }
 
+    private static User lastUser = null;
+
     /**
      * Creates a user known to the OSM server
@@ -67 +69 @@
      */
     public static synchronized User createOsmUser(long uid, String name) {
-        User user = userMap.get(uid);
+
+        if (lastUser != null && lastUser.getId() == uid) {
+            return lastUser;
+        }
+
+        Long ouid = uid;
+        User user = userMap.get(ouid);
         if (user == null) {
             user = new User(uid, name);
-            userMap.put(user.getId(), user);
+            userMap.put(ouid, user);
         }
         if (name != null) user.addName(name);
+
+        lastUser = user;
+
         return user;
     }