Changeset 8581 in josm for trunk/src/org/openstreetmap

Timestamp:

2015-07-07T23:45:23+02:00 (9 years ago)

Author:

Don-vip

Message:

fix #11664 - fix regression of r8566 for relation editor

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TagEditorModel.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TagEditorModel.java

@@ -31 +31 @@
  *
  */
-@SuppressWarnings("serial")
 public class TagEditorModel extends AbstractTableModel {
     public static final String PROP_DIRTY = TagEditorModel.class.getName() + ".dirty";
@@ -407 +406 @@
      */
     public void applyToPrimitive(Tagged primitive) {
-        Map<String, String> tags = primitive.getKeys();
-        applyToTags(tags, false);
-        primitive.setKeys(tags);
+        primitive.setKeys(applyToTags(false));
     }
 
@@ -415 +412 @@
      * applies the current state of the tag editor model to a map of tags
      *
-     * @param tags the map of key/value pairs
-     *
-     */
-    public void applyToTags(Map<String, String> tags, boolean keepEmpty) {
-        tags.clear();
+     * @return the map of key/value pairs
+     */
+    private Map<String, String> applyToTags(boolean keepEmpty) {
+        Map<String, String> result = new HashMap<>();
         for (TagModel tag: this.tags) {
             // tag still holds an unchanged list of different values for the same key.
@@ -432 +428 @@
                 continue;
             }
-            tags.put(tag.getName().trim(), tag.getValue().trim());
-        }
+            result.put(tag.getName().trim(), tag.getValue().trim());
+        }
+        return result;
     }
 
@@ -441 +438 @@
 
     public Map<String, String> getTags(boolean keepEmpty) {
-        Map<String, String> tags = new HashMap<>();
-        applyToTags(tags, keepEmpty);
-        return tags;
+        return applyToTags(keepEmpty);
     }