Changeset 8565 in josm

Timestamp:

2015-07-04T18:31:20+02:00 (9 years ago)

Author:

Don-vip

Message:

fix #11650 - performance: avoid creation of Date objects when it is not needed (patch by shinigami, modified slightly)

Location:

trunk

Files:

• src/org/openstreetmap/josm/actions/search/SearchCompiler.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/osm/DataSetMerger.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/IPrimitive.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) (1 diff)
• src/org/openstreetmap/josm/io/OsmWriter.java (modified) (1 diff)
• src/org/openstreetmap/josm/tools/date/DateUtils.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/data/osm/DataSetMergerTest.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java

@@ -567 +567 @@
 
                 if ("timestamp".equals(key)) {
-                    mv = DateUtils.fromDate(osm.getTimestamp());
+                    mv = DateUtils.fromTimestamp(osm.getRawTimestamp());
                 } else {
                     mv = osm.get(key);
@@ -1087 +1087 @@
         @Override
         protected Long getNumber(OsmPrimitive osm) {
-            return osm.getTimestamp().getTime();
+            return osm.getRawTimestamp() * 1000L;
         }
 

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -292 +292 @@
     }
 
+    @Override
+    public void setRawTimestamp(int timestamp) {
+        this.timestamp = timestamp;
+    }
+
     /**
      * Time of last modification to this object. This is not set by JOSM but
@@ -302 +307 @@
     public Date getTimestamp() {
         return new Date(timestamp * 1000L);
+    }
+
+    @Override
+    public int getRawTimestamp() {
+        return timestamp;
     }
 

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -100 +100 @@
                     target.setVisible(source.isVisible());
                     target.setUser(source.getUser());
-                    target.setTimestamp(source.getTimestamp());
+                    target.setRawTimestamp(source.getRawTimestamp());
                     target.setModified(source.isModified());
                     objectsWithChildrenToMerge.add(source.getPrimitiveId());

trunk/src/org/openstreetmap/josm/data/osm/IPrimitive.java

@@ -41 +41 @@
     Date getTimestamp();
 
+    int getRawTimestamp();
+
     void setTimestamp(Date timestamp);
+
+    void setRawTimestamp(int timestamp);
 
     boolean isTimestampEmpty();

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -1228 +1228 @@
         // Write lock is provided by subclasses
         setKeys(data.getKeys());
-        setTimestamp(data.getTimestamp());
+        setRawTimestamp(data.getRawTimestamp());
         user = data.getUser();
         setChangesetId(data.getChangesetId());
@@ -1250 +1250 @@
         data.setId(id);
         data.setKeys(getKeys());
-        data.setTimestamp(getTimestamp());
+        data.setRawTimestamp(getRawTimestamp());
         data.setUser(user);
         data.setDeleted(isDeleted());

trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java

@@ -233 +233 @@
             add(tr("Data Set: "), Integer.toHexString(o.getDataSet().hashCode()));
             add(tr("Edited at: "), o.isTimestampEmpty() ? tr("<new object>")
-                    : DateUtils.fromDate(o.getTimestamp()));
+                    : DateUtils.fromTimestamp(o.getRawTimestamp()));
             add(tr("Edited by: "), o.getUser() == null ? tr("<new object>")
                     : getNameAndId(o.getUser().getName(), o.getUser().getId()));

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -597 +597 @@
 
         if (!n.isTimestampEmpty()) {
-            wpt.put("time", DateUtils.fromDate(n.getTimestamp()));
+            wpt.put("time", DateUtils.fromTimestamp(n.getRawTimestamp()));
             wpt.setTime();
         }

trunk/src/org/openstreetmap/josm/io/OsmWriter.java

@@ -299 +299 @@
             }
             if (!osm.isTimestampEmpty()) {
-                out.print(" timestamp='"+DateUtils.fromDate(osm.getTimestamp())+"'");
+                out.print(" timestamp='"+DateUtils.fromTimestamp(osm.getRawTimestamp())+"'");
             }
             // user and visible added with 0.4 API

trunk/src/org/openstreetmap/josm/tools/date/DateUtils.java

@@ -119 +119 @@
     }
 
+    private static String toXmlFormat(GregorianCalendar cal) {
+        XMLGregorianCalendar xgc = XML_DATE.newXMLGregorianCalendar(cal);
+        if (cal.get(Calendar.MILLISECOND) == 0) {
+            xgc.setFractionalSecond(null);
+        }
+        return xgc.toXMLFormat();
+    }
+
+    /**
+     * Formats a date to the XML UTC format regardless of current locale.
+     * @param timestamp number of seconds since the epoch
+     * @return The formatted date
+     */
+    public static synchronized String fromTimestamp(int timestamp) {
+        calendar.setTimeInMillis(timestamp * 1000L);
+        return toXmlFormat(calendar);
+    }
+
     /**
      * Formats a date to the XML UTC format regardless of current locale.
@@ -126 +144 @@
     public static synchronized String fromDate(Date date) {
         calendar.setTime(date);
-        XMLGregorianCalendar xgc = XML_DATE.newXMLGregorianCalendar(calendar);
-        if (calendar.get(Calendar.MILLISECOND) == 0) xgc.setFractionalSecond(null);
-        return xgc.toXMLFormat();
+        return toXmlFormat(calendar);
     }
 

trunk/test/unit/org/openstreetmap/josm/data/osm/DataSetMergerTest.java

@@ -317 +317 @@
         their.addPrimitive(n1);
 
-
         DataSetMerger visitor = new DataSetMerger(my, their);
         visitor.merge();
@@ -324 +323 @@
         assertEquals(0, visitor.getConflicts().size());
         assertEquals("value1", n2.get("key1"));
-        assertTrue(n1.getTimestamp().equals(n2.getTimestamp()));
+        assertEquals(n1.getRawTimestamp(), n2.getRawTimestamp());
         assertEquals(theirUser, n2.getUser());
         assertSame(n2, n);
@@ -351 +350 @@
         their.addPrimitive(n1);
 
-
         DataSetMerger visitor = new DataSetMerger(my, their);
         visitor.merge();
@@ -358 +356 @@
         assertEquals(0, visitor.getConflicts().size());
         assertEquals("value1", n2.get("key1"));
-        assertTrue(n1.getTimestamp().equals(n2.getTimestamp()));
+        assertEquals(n1.getRawTimestamp(), n2.getRawTimestamp());
         assertFalse(n2.isIncomplete());
         assertSame(n2, n);
@@ -665 +663 @@
         assertEquals("their", merged.getUser().getName());
         assertEquals(1111, merged.getUser().getId());
-        assertEquals(theirWay.getTimestamp(), merged.getTimestamp());
+        assertEquals(theirWay.getRawTimestamp(), merged.getRawTimestamp());
         assertSame(merged, myWay);
         assertSame(merged.getNode(0), n1);
@@ -719 +717 @@
         assertEquals("their", merged.getUser().getName());
         assertEquals(1111, merged.getUser().getId());
-        assertEquals(theirWay.getTimestamp(), merged.getTimestamp());
+        assertEquals(theirWay.getRawTimestamp(), merged.getRawTimestamp());
         assertSame(merged, myWay);
         assertSame(merged.getNode(0), n1);