Changeset 8514 in josm for trunk/test/unit

Timestamp:

2015-06-21T03:19:37+02:00 (10 years ago)

Author:

Don-vip

Message:

checkstyle: various checks

Location:

trunk/test/unit/org

Files:

• CustomMatchers.java (modified) (2 diffs)
• openstreetmap/josm/TestUtils.java (modified) (1 diff)
• openstreetmap/josm/data/osm/history/HistoryNodeTest.java (modified) (1 diff)
• openstreetmap/josm/gui/conflict/nodes/NodeListMergeModelTest.java (modified) (1 diff)

trunk/test/unit/org/CustomMatchers.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org;
+
+import java.util.Collection;
 
 import org.hamcrest.Description;
@@ -8 +10 @@
 import org.openstreetmap.josm.tools.Predicate;
 
-import java.util.Collection;
+@Ignore("no test")
+public final class CustomMatchers {
 
-@Ignore("no test")
-public class CustomMatchers {
+    private CustomMatchers() {
+        // Hide constructor for utility classes
+    }
 
     public static <T> Matcher<? extends T> forPredicate(final Predicate<T> predicate) {

trunk/test/unit/org/openstreetmap/josm/TestUtils.java

@@ -10 +10 @@
  * Various utils, useful for unit tests.
  */
-public class TestUtils {
+public final class TestUtils {
+
+    private TestUtils() {
+        // Hide constructor for utility classes
+    }
 
     /**

trunk/test/unit/org/openstreetmap/josm/data/osm/history/HistoryNodeTest.java

@@ -18 +18 @@
         Date d = new Date();
         HistoryNode node = new HistoryNode(
-                1l,
-                2l,
+                1L,
+                2L,
                 true,
                 User.createOsmUser(3, "testuser"),
-                4l,
+                4L,
                 d,
                 new LatLon(0, 0)

trunk/test/unit/org/openstreetmap/josm/gui/conflict/nodes/NodeListMergeModelTest.java

@@ -60 +60 @@
             }
             try {
-                int rows[] = (int[]) idx[i];
+                int[] rows = (int[]) idx[i];
                 if (rows.length != 2) {
                     fail("illegal selection range. Either null or not length 2: " + Arrays.toString(rows));