Changeset 8459 in josm for trunk/test/unit/org

Timestamp:

2015-06-03T13:24:59+02:00 (9 years ago)

Author:

Don-vip

Message:

javadoc / Unit test fixes

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/NameMismatchTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/NameMismatchTest.java

@@ -13 +13 @@
 import org.openstreetmap.josm.data.validation.TestError;
 
+/**
+ * JUnit Test of "Name mismatch" validation test.
+ */
 public class NameMismatchTest {
 
+    /**
+     * Setup test.
+     */
     @Before
     public void setUp() {
@@ -26 +32 @@
     }
 
+    /**
+     * Test "A name is missing, even though name:* exists."
+     */
     @Test
     public void test0() {
         final List<TestError> errors = test("node name:de=Europa");
-        assertSame(errors.size(), 1);
-        assertEquals(errors.get(0).getDescription(), "A name is missing, even though name:* exists.");
+        assertSame(1, errors.size());
+        assertEquals("A name is missing, even though name:* exists.", errors.get(0).getMessage());
     }
 
+    /**
+     * Test "Missing name:*={0}. Add tag with correct language key."
+     */
     @Test
     public void test1() {
         final List<TestError> errors = test("node name=Europe name:de=Europa");
-        assertSame(errors.size(), 1);
-        assertEquals(errors.get(0).getDescription(), "Missing name:*=Europe. Add tag with correct language key.");
+        assertSame(1, errors.size());
+        assertEquals("Missing name:*=Europe. Add tag with correct language key.", errors.get(0).getDescription());
     }
 
+    /**
+     * Test no error
+     */
     @Test
     public void test2() {
         final List<TestError> errors = test("node name=Europe name:de=Europa name:en=Europe");
-        assertSame(errors.size(), 0);
+        assertSame(0, errors.size());
     }
 
+    /**
+     * Various other tests
+     */
     @Test
     public void test3() {
         List<TestError> errors;
         errors = test("node \"name\"=\"Italia - Italien - Italy\"");
-        assertSame(errors.size(), 0);
+        assertSame(0, errors.size());
         errors = test("node name=\"Italia - Italien - Italy\" name:it=Italia");
-        assertSame(errors.size(), 2);
+        assertSame(2, errors.size());
         errors = test("node name=\"Italia - Italien - Italy\" name:it=Italia name:de=Italien");
-        assertSame(errors.size(), 1);
-        assertEquals(errors.get(0).getDescription(), "Missing name:*=Italy. Add tag with correct language key.");
+        assertSame(1, errors.size());
+        assertEquals("Missing name:*=Italy. Add tag with correct language key.", errors.get(0).getDescription());
         errors = test("node name=\"Italia - Italien - Italy\" name:it=Italia name:de=Italien name:en=Italy");
-        assertSame(errors.size(), 0);
+        assertSame(0, errors.size());
     }
 }