Changeset 8377 in josm for trunk/src/org/openstreetmap/josm/gui/widgets

Timestamp:

2015-05-17T04:02:42+02:00 (10 years ago)

Author:

Don-vip

Message:

performance - remove useless boxing of boolean constants

Location:

trunk/src/org/openstreetmap/josm/gui/widgets

Files:

• AbstractTextComponentValidator.java (modified) (2 diffs)
• JosmComboBox.java (modified) (1 diff)
• JosmEditorPane.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/widgets/AbstractTextComponentValidator.java

@@ -46 +46 @@
     protected void feedbackInvalid(String msg) {
         if (valid == null || valid || !Objects.equals(msg, this.msg)) {
-            // only provide feedback if the validity has changed. This avoids
-            // unnecessary UI updates.
+            // only provide feedback if the validity has changed. This avoids unnecessary UI updates.
             tc.setBorder(ERROR_BORDER);
             tc.setBackground(ERROR_BACKGROUND);
             tc.setToolTipText(msg);
-            valid = false;
+            valid = Boolean.FALSE;
             this.msg = msg;
         }
@@ -62 +61 @@
     protected void feedbackValid(String msg) {
         if (valid == null || !valid || !Objects.equals(msg, this.msg)) {
-            // only provide feedback if the validity has changed. This avoids
-            // unnecessary UI updates.
+            // only provide feedback if the validity has changed. This avoids unnecessary UI updates.
             tc.setBorder(UIManager.getBorder("TextField.border"));
             tc.setBackground(UIManager.getColor("TextField.background"));
             tc.setToolTipText(msg == null ? "" : msg);
-            valid = true;
+            valid = Boolean.TRUE;
             this.msg = msg;
         }

trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

@@ -184 +184 @@
         public void propertyChange(PropertyChangeEvent evt) {
             if ("editable".equals(evt.getPropertyName())) {
-                if (evt.getNewValue().equals(true)) {
+                if (evt.getNewValue().equals(Boolean.TRUE)) {
                     enableMenu();
                 } else {

trunk/src/org/openstreetmap/josm/gui/widgets/JosmEditorPane.java

@@ -125 +125 @@
             defaults.put("EditorPane[Enabled].backgroundPainter", bgColor);
             pane.putClientProperty("Nimbus.Overrides", defaults);
-            pane.putClientProperty("Nimbus.Overrides.InheritDefaults", true);
+            pane.putClientProperty("Nimbus.Overrides.InheritDefaults", Boolean.TRUE);
             pane.setBackground(bgColor);
         }