Changeset 8373 in josm

Timestamp:

2015-05-17T02:40:26+02:00 (9 years ago)

Author:

Don-vip

Message:

code style - Method makes literal string comparisons passing the literal as an argument

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/gpx/GpxData.java (modified) (1 diff)
• data/validation/tests/MapCSSTagChecker.java (modified) (1 diff)
• gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (1 diff)
• gui/layer/geoimage/GeoImageLayer.java (modified) (1 diff)
• gui/mappaint/mapcss/Instruction.java (modified) (2 diffs)
• gui/mappaint/mapcss/MapCSSStyleSource.java (modified) (1 diff)
• gui/preferences/server/OsmApiUrlInputPanel.java (modified) (2 diffs)
• io/GpxWriter.java (modified) (2 diffs)
• tools/I18n.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java

@@ -54 +54 @@
             // TODO: Detect conflicts.
             String k = ent.getKey();
-            if (k.equals(META_LINKS) && attr.containsKey(META_LINKS)) {
+            if (META_LINKS.equals(k) && attr.containsKey(META_LINKS)) {
                 Collection<GpxLink> my = super.<GpxLink>getCollection(META_LINKS);
                 @SuppressWarnings("unchecked")

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -292 +292 @@
                         check.fixCommands.add(FixCommand.fixChangeKey(Tag.removeWhiteSpaces(x[0]), Tag.removeWhiteSpaces(x[1])));
                     } else if ("fixDeleteObject".equals(ai.key) && val != null) {
-                        CheckParameterUtil.ensureThat(val.equals("this"), "fixDeleteObject must be followed by 'this'");
+                        CheckParameterUtil.ensureThat("this".equals(val), "fixDeleteObject must be followed by 'this'");
                         check.deletion = true;
                     } else if ("suggestAlternative".equals(ai.key) && val != null) {

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -482 +482 @@
         @Override
         public void propertyChange(PropertyChangeEvent evt) {
-            if (evt.getPropertyName().equals(JSplitPane.DIVIDER_LOCATION_PROPERTY)) {
+            if (JSplitPane.DIVIDER_LOCATION_PROPERTY.equals(evt.getPropertyName())) {
                 int newVal = (Integer) evt.getNewValue();
                 if (getHeight() != 0) {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -626 +626 @@
             double speed = dirGps.getDouble(GpsDirectory.TAG_SPEED);
             String speedRef = dirGps.getString(GpsDirectory.TAG_SPEED_REF);
-            if (speedRef != null) {
-                if (speedRef.equalsIgnoreCase("M")) {
-                    // miles per hour
-                    speed *= 1.609344;
-                } else if (speedRef.equalsIgnoreCase("N")) {
-                    // knots == nautical miles per hour
-                    speed *= 1.852;
-                }
-                // default is K (km/h)
-            }
+            if ("M".equalsIgnoreCase(speedRef)) {
+                // miles per hour
+                speed *= 1.609344;
+            } else if ("N".equalsIgnoreCase(speedRef)) {
+                // knots == nautical miles per hour
+                speed *= 1.852;
+            }
+            // default is K (km/h)
             e.setSpeed(speed);
         } catch (Exception ex) {

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Instruction.java

@@ -40 +40 @@
                 if (litValue instanceof Keyword && "none".equals(((Keyword) litValue).val)) {
                     this.val = null;
-                } else if (key.equals(TEXT)) {
+                } else if (TEXT.equals(key)) {
                     /* Special case for declaration 'text: ...'
                      *
@@ -77 +77 @@
                 value = val;
             }
-            if (key.equals(ICON_IMAGE) || key.equals(FILL_IMAGE) || key.equals(REPEAT_IMAGE)) {
+            if (ICON_IMAGE.equals(key) || FILL_IMAGE.equals(key) || REPEAT_IMAGE.equals(key)) {
                 if (value instanceof String) {
                     value = new IconReference((String) value, env.source);

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSStyleSource.java

@@ -538 +538 @@
             if (r.selector instanceof GeneralSelector) {
                 GeneralSelector gs = (GeneralSelector) r.selector;
-                if (gs.getBase().equals("setting")) {
+                if ("setting".equals(gs.getBase())) {
                     if (!gs.matchesConditions(env)) {
                         continue;

trunk/src/org/openstreetmap/josm/gui/preferences/server/OsmApiUrlInputPanel.java

@@ -119 +119 @@
     public void initFromPreferences() {
         String url =  Main.pref.get("osm-server.url", OsmApi.DEFAULT_API_URL);
-        if (url.trim().equals(OsmApi.DEFAULT_API_URL)) {
+        if (OsmApi.DEFAULT_API_URL.equals(url.trim())) {
             cbUseDefaultServerUrl.setSelected(true);
             propagator.propagate(OsmApi.DEFAULT_API_URL);
@@ -137 +137 @@
         if (cbUseDefaultServerUrl.isSelected()) {
             Main.pref.put("osm-server.url", null);
-        } else if (hmiUrl.equals(OsmApi.DEFAULT_API_URL)) {
+        } else if (OsmApi.DEFAULT_API_URL.equals(hmiUrl)) {
             Main.pref.put("osm-server.url", null);
         } else {

trunk/src/org/openstreetmap/josm/io/GpxWriter.java

@@ -95 +95 @@
     private void writeAttr(IWithAttributes obj, List<String> keys) {
         for (String key : keys) {
-            if (key.equals(META_LINKS)) {
+            if (META_LINKS.equals(key)) {
                 Collection<GpxLink> lValue = obj.<GpxLink>getCollection(key);
                 if (lValue != null) {
@@ -102 +102 @@
                     }
                 }
-            } else if (key.equals(META_EXTENSIONS)) {
+            } else if (META_EXTENSIONS.equals(key)) {
                 Extensions extensions = (Extensions) obj.get(key);
                 if (extensions != null) {

trunk/src/org/openstreetmap/josm/tools/I18n.java

@@ -451 +451 @@
         if ("en".equals(loadedCode))
             return;
-        String enfile = "data/en.lang";
-        String langfile = "data/"+loadedCode+".lang";
+        final String enfile = "data/en.lang";
+        final String langfile = "data/"+loadedCode+".lang";
         try (
             FileInputStream fis = new FileInputStream(source);
@@ -461 +461 @@
             while (!found && (e = jar.getNextEntry()) != null) {
                 String name = e.getName();
-                if(name.equals(enfile))
+                if (enfile.equals(name))
                     found = true;
             }