Changeset 8171 in josm

Timestamp:

2015-04-06T14:59:42+02:00 (10 years ago)

Author:

stoecker

Message:

fix #7630 - provide a zoom to all downloaded areas function

File:

• trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java (modified) (18 diffs)

trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java

@@ -8 +8 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -22 +23 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.Bounds;
+import org.openstreetmap.josm.data.DataSource;
 import org.openstreetmap.josm.data.conflict.Conflict;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
@@ -31 +33 @@
 import org.openstreetmap.josm.gui.dialogs.LayerListDialog;
 import org.openstreetmap.josm.gui.dialogs.ValidatorDialog.ValidatorBoundingXYVisitor;
-import org.openstreetmap.josm.gui.download.DownloadDialog;
 import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.tools.Shortcut;
@@ -55 +56 @@
     protected ZoomChangeAdapter zoomChangeAdapter;
     protected MapFrameAdapter mapFrameAdapter;
+    /** Time of last zoom to bounds action */
+    protected long lastZoomTime = -1;
+    /** Last zommed bounds */
+    protected int lastZoomArea = -1;
 
     /**
@@ -63 +68 @@
      */
     public static void zoomToSelection() {
-        if (Main.main == null || !Main.main.hasEditLayer()) return;
+        if (Main.main == null || !Main.main.hasEditLayer())
+            return;
         Collection<OsmPrimitive> sel = Main.main.getEditLayer().data.getSelected();
         if (sel.isEmpty()) {
@@ -70 +76 @@
                     tr("Nothing selected to zoom to."),
                     tr("Information"),
-                    JOptionPane.INFORMATION_MESSAGE
-            );
+                    JOptionPane.INFORMATION_MESSAGE);
             return;
         }
@@ -126 +131 @@
     public AutoScaleAction(final String mode) {
         super(tr("Zoom to {0}", tr(mode)), "dialogs/autoscale/" + mode, tr("Zoom the view to {0}.", tr(mode)),
-                Shortcut.registerShortcut("view:zoom"+mode, tr("View: {0}", tr("Zoom to {0}", tr(mode))), getModeShortcut(mode), Shortcut.DIRECT),
-                true, null, false);
+                Shortcut.registerShortcut("view:zoom" + mode, tr("View: {0}", tr("Zoom to {0}", tr(mode))),
+                        getModeShortcut(mode), Shortcut.DIRECT), true, null, false);
         String modeHelp = Character.toUpperCase(mode.charAt(0)) + mode.substring(1);
         putValue("help", "Action/AutoScale/" + modeHelp);
@@ -157 +162 @@
             break;
         default:
-            throw new IllegalArgumentException("Unknown mode: "+mode);
+            throw new IllegalArgumentException("Unknown mode: " + mode);
         }
         installAdapters();
     }
 
-    public void autoScale()  {
+    public void autoScale() {
         if (Main.isDisplayingMapView()) {
-            switch(mode) {
+            switch (mode) {
             case "previous":
                 Main.map.mapView.zoomPrevious();
@@ -195 +200 @@
     protected Layer getFirstSelectedLayer() {
         List<Layer> layers = LayerListDialog.getInstance().getModel().getSelectedLayers();
-        if (layers.isEmpty()) return null;
+        if (layers.isEmpty())
+            return null;
         return layers.get(0);
     }
@@ -202 +208 @@
         BoundingXYVisitor v = "problem".equals(mode) ? new ValidatorBoundingXYVisitor() : new BoundingXYVisitor();
 
-        switch(mode) {
+        switch (mode) {
         case "problem":
             TestError error = Main.map.validatorDialog.getSelectedError();
-            if (error == null) return null;
+            if (error == null)
+                return null;
             ((ValidatorBoundingXYVisitor) v).visit(error);
-            if (v.getBounds() == null) return null;
+            if (v.getBounds() == null)
+                return null;
             v.enlargeBoundingBox(Main.pref.getDouble("validator.zoom-enlarge-bbox", 0.0002));
             break;
@@ -220 +228 @@
             // try to zoom to the first selected layer
             Layer l = getFirstSelectedLayer();
-            if (l == null) return null;
+            if (l == null)
+                return null;
             l.visitBoundingBox(v);
             break;
@@ -241 +250 @@
                         ("selection".equals(mode) ? tr("Nothing selected to zoom to.") : tr("No conflicts to zoom to")),
                         tr("Information"),
-                        JOptionPane.INFORMATION_MESSAGE
-                );
+                        JOptionPane.INFORMATION_MESSAGE);
                 return null;
             }
@@ -256 +264 @@
             break;
         case "download":
-            Bounds bounds = DownloadDialog.getSavedDownloadBounds();
-            if (bounds != null) {
-                try {
-                    v.visit(bounds);
-                } catch (Exception e) {
-                    Main.warn(e);
-                }
+
+            if (lastZoomTime > 0 && System.currentTimeMillis() - lastZoomTime > Main.pref.getLong("zoom.bounds.reset.time", 10*1000)) {
+                lastZoomTime = -1;
+            }
+            ArrayList<DataSource> dataSources = new ArrayList<>(Main.main.getCurrentDataSet().getDataSources());
+            int s = dataSources.size();
+            if(s > 0) {
+                if(lastZoomTime == -1 || lastZoomArea == -1 || lastZoomArea > s) {
+                    lastZoomArea = s-1;
+                    v.visit(dataSources.get(lastZoomArea).bounds);
+                } else if(lastZoomArea > 0) {
+                    lastZoomArea -= 1;
+                    v.visit(dataSources.get(lastZoomArea).bounds);
+                } else {
+                    lastZoomArea = -1;
+                    v.visit(new Bounds(Main.main.getCurrentDataSet().getDataSourceArea().getBounds2D()));
+                }
+                lastZoomTime = System.currentTimeMillis();
+            } else {
+                lastZoomTime = -1;
+                lastZoomArea = -1;
             }
             break;
@@ -271 +293 @@
     @Override
     protected void updateEnabledState() {
-        switch(mode) {
+        switch (mode) {
         case "selection":
-            setEnabled(getCurrentDataSet() != null && ! getCurrentDataSet().getSelected().isEmpty());
+            setEnabled(getCurrentDataSet() != null && !getCurrentDataSet().getSelected().isEmpty());
             break;
         case "layer":
@@ -296 +318 @@
             break;
         default:
-            setEnabled(Main.isDisplayingMapView() && Main.map.mapView.hasLayers()
-            );
+            setEnabled(Main.isDisplayingMapView() && Main.map.mapView.hasLayers());
         }
     }
@@ -338 +359 @@
             if ("conflict".equals(mode)) {
                 conflictSelectionListener = new ListSelectionListener() {
-                    @Override public void valueChanged(ListSelectionEvent e) {
+                    @Override
+                    public void valueChanged(ListSelectionEvent e) {
                         updateEnabledState();
                     }
@@ -344 +366 @@
             } else if ("problem".equals(mode)) {
                 validatorSelectionListener = new TreeSelectionListener() {
-                    @Override public void valueChanged(TreeSelectionEvent e) {
+                    @Override
+                    public void valueChanged(TreeSelectionEvent e) {
                         updateEnabledState();
                     }
@@ -351 +374 @@
         }
 
-        @Override public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) {
+        @Override
+        public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) {
             if (conflictSelectionListener != null) {
                 if (newFrame != null) {