Changeset 8126 in josm for trunk/src

Timestamp:

2015-03-08T23:39:57+01:00 (9 years ago)

Author:

Don-vip

Message:

fix Sonar issue squid:S2444 - Lazy initialization of "static" fields should be "synchronized"

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (7 diffs)
• actions/ImageryAdjustAction.java (modified) (1 diff)
• actions/search/SearchAction.java (modified) (1 diff)
• corrector/CorrectionTable.java (modified) (1 diff)
• data/Version.java (modified) (1 diff)
• data/coor/CoordinateFormat.java (modified) (1 diff)
• data/osm/history/HistoryDataSet.java (modified) (1 diff)
• data/osm/visitor/paint/MapRendererFactory.java (modified) (1 diff)
• data/osm/visitor/paint/PaintColors.java (modified) (2 diffs)
• data/osm/visitor/paint/relations/Multipolygon.java (modified) (1 diff)
• data/validation/OsmValidator.java (modified) (1 diff)
• data/validation/tests/MultipolygonTest.java (modified) (2 diffs)
• data/validation/tests/TagChecker.java (modified) (4 diffs)
• data/validation/util/Entities.java (modified) (1 diff)
• gui/DefaultNameFormatter.java (modified) (2 diffs)
• gui/FileDrop.java (modified) (1 diff)
• gui/JosmUserIdentityManager.java (modified) (2 diffs)
• gui/NotificationManager.java (modified) (1 diff)
• gui/actionsupport/DeleteFromRelationConfirmationDialog.java (modified) (1 diff)
• gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (1 diff)
• gui/dialogs/LayerListDialog.java (modified) (1 diff)
• gui/dialogs/changeset/ChangesetCacheManager.java (modified) (1 diff)
• gui/download/DownloadDialog.java (modified) (1 diff)
• gui/help/HelpBrowser.java (modified) (1 diff)
• gui/history/HistoryBrowserDialogManager.java (modified) (1 diff)
• gui/io/ChangesetCommentModel.java (modified) (4 diffs)
• gui/io/UploadDialog.java (modified) (1 diff)
• gui/layer/JumpToMarkerActions.java (modified) (1 diff)
• gui/layer/OsmDataLayer.java (modified) (1 diff)
• gui/layer/geoimage/GeoImageLayer.java (modified) (1 diff)
• gui/layer/geoimage/ImageViewerDialog.java (modified) (1 diff)
• gui/layer/markerlayer/AudioMarker.java (modified) (1 diff)
• gui/layer/markerlayer/PlayHeadMarker.java (modified) (1 diff)
• gui/mappaint/BoxTextElemStyle.java (modified) (1 diff)
• gui/mappaint/StyleSource.java (modified) (1 diff)
• gui/preferences/server/OAuthAccessTokenHolder.java (modified) (1 diff)
• gui/tagging/TaggingPresetNameTemplateList.java (modified) (1 diff)
• gui/tagging/TaggingPresetReader.java (modified) (1 diff)
• gui/tagging/TaggingPresetSearchDialog.java (modified) (1 diff)
• gui/tagging/TaggingPresetSearchPrimitiveDialog.java (modified) (3 diffs)
• gui/util/FileFilterAllFiles.java (modified) (2 diffs)
• gui/util/StayOpenCheckBoxMenuItem.java (modified) (1 diff)
• gui/util/StayOpenMenuItem.java (modified) (1 diff)
• gui/util/StayOpenRadioButtonMenuItem.java (modified) (1 diff)
• gui/widgets/AbstractFileChooser.java (modified) (1 diff)
• io/MessageNotifier.java (modified) (1 diff)
• io/OsmReader.java (modified) (1 diff)
• io/OsmServerWriter.java (modified) (1 diff)
• io/OsmWriterFactory.java (modified) (1 diff)
• io/auth/CredentialsManager.java (modified) (1 diff)
• io/auth/DefaultAuthenticator.java (modified) (1 diff)
• io/remotecontrol/RemoteControlHttpServer.java (modified) (1 diff)
• io/remotecontrol/RemoteControlHttpsServer.java (modified) (1 diff)
• plugins/PluginHandler.java (modified) (1 diff)
• tools/AudioPlayer.java (modified) (1 diff)
• tools/BugReportExceptionHandler.java (modified) (1 diff)
• tools/I18n.java (modified) (2 diffs)
• tools/ImageProvider.java (modified) (1 diff)
• tools/MultikeyActionsHandler.java (modified) (1 diff)
• tools/RightAndLefthandTraffic.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -154 +154 @@
      * Global application.
      */
-    public static Main main;
+    public static volatile Main main;
 
     /**
@@ -191 +191 @@
      * The toolbar preference control to register new actions.
      */
-    public static ToolbarPreferences toolbar;
+    public static volatile ToolbarPreferences toolbar;
 
     /**
@@ -468 +468 @@
      * to the JOSM team for inclusion.
      */
-    public static PlatformHook platform;
+    public static volatile PlatformHook platform;
 
     /**
@@ -525 +525 @@
     }
 
-    private static InitStatusListener initListener = null;
+    private static volatile InitStatusListener initListener = null;
 
     public static interface InitStatusListener {
@@ -892 +892 @@
     public static final JPanel panel = new JPanel(new BorderLayout());
 
-    protected static WindowGeometry geometry;
+    protected static volatile WindowGeometry geometry;
     protected static int windowState = JFrame.NORMAL;
 
@@ -1305 +1305 @@
      * Use {@link #setProjection(Projection)} in order to trigger a projection change event.
      */
-    private static Projection proj;
+    private static volatile Projection proj;
 
     /**
@@ -1481 +1481 @@
         private static MasterWindowListener INSTANCE;
 
-        public static MasterWindowListener getInstance() {
+        public static synchronized MasterWindowListener getInstance() {
             if (INSTANCE == null) {
                 INSTANCE = new MasterWindowListener();

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -39 +39 @@
  */
 public class ImageryAdjustAction extends MapMode implements MouseListener, MouseMotionListener, AWTEventListener{
-    private static ImageryOffsetDialog offsetDialog;
+    private static volatile ImageryOffsetDialog offsetDialog;
     private static Cursor cursor = ImageProvider.getCursor("normal", "move");
 

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -125 +125 @@
     }
 
-    private static SearchSetting lastSearch = null;
+    private static volatile SearchSetting lastSearch = null;
 
     /**

trunk/src/org/openstreetmap/josm/corrector/CorrectionTable.java

@@ -32 +32 @@
     }
 
-    private static BoldRenderer boldRenderer = null;
+    private static volatile BoldRenderer boldRenderer = null;
 
     protected CorrectionTable(T correctionTableModel) {

trunk/src/org/openstreetmap/josm/data/Version.java

@@ -57 +57 @@
      * @return the unique instance of the version information
      */
-    public static Version getInstance() {
+    public static synchronized Version getInstance() {
         if (instance == null) {
             instance = new Version();

trunk/src/org/openstreetmap/josm/data/coor/CoordinateFormat.java

@@ -49 +49 @@
     }
 
-    private static CoordinateFormat defaultCoordinateFormat = DECIMAL_DEGREES;
+    private static volatile CoordinateFormat defaultCoordinateFormat = DECIMAL_DEGREES;
 
     /**

trunk/src/org/openstreetmap/josm/data/osm/history/HistoryDataSet.java

@@ -35 +35 @@
      * @return the unique instance of the history data set
      */
-    public static HistoryDataSet getInstance() {
+    public static synchronized HistoryDataSet getInstance() {
         if (historyDataSet == null) {
             historyDataSet = new HistoryDataSet();

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/MapRendererFactory.java

@@ -91 +91 @@
      * @return instance of map rending class
      */
-    public static MapRendererFactory getInstance() {
+    public static synchronized MapRendererFactory getInstance() {
         if (instance == null) {
             instance = new MapRendererFactory();

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/PaintColors.java

@@ -10 +10 @@
 import org.openstreetmap.josm.data.Preferences.ColorKey;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
+import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.MapPaintSylesUpdateListener;
 import org.openstreetmap.josm.gui.mappaint.StyleSource;
-import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.MapPaintSylesUpdateListener;
 
 public enum PaintColors implements ColorKey {
@@ -35 +35 @@
     private final Color defaultColor;
 
-    private static Color backgroundColorCache = null;
+    private static volatile Color backgroundColorCache = null;
 
     private static final MapPaintSylesUpdateListener styleOverrideListener = new MapPaintSylesUpdateListener() {

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java

@@ -149 +149 @@
      */
     private static MultipolygonRoleMatcher roleMatcher;
-    private static MultipolygonRoleMatcher getMultipolygonRoleMatcher() {
+    private static synchronized MultipolygonRoleMatcher getMultipolygonRoleMatcher() {
         if (roleMatcher == null) {
             roleMatcher = new MultipolygonRoleMatcher();

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -72 +72 @@
 public class OsmValidator implements LayerChangeListener {
 
-    public static ValidatorLayer errorLayer = null;
+    public static volatile ValidatorLayer errorLayer = null;
 
     /** The validate action */

trunk/src/org/openstreetmap/josm/data/validation/tests/MultipolygonTest.java

@@ -57 +57 @@
     protected static final int OUTER_STYLE = 1613;
 
-    private static ElemStyles styles;
+    private static volatile ElemStyles styles;
 
     private final List<List<Node>> nonClosedWays = new ArrayList<>();
@@ -222 +222 @@
                     } else {
                         /* old style multipolygon - solve: copy tags from outer way to multipolygon */
-                        addError(r, new TestError(this, Severity.WARNING, 
+                        addError(r, new TestError(this, Severity.WARNING,
                                 trn("Multipolygon relation should be tagged with area tags and not the outer way",
                                         "Multipolygon relation should be tagged with area tags and not the outer ways", polygon.getOuterWays().size()),

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -71 +71 @@
 
     /** The spell check key substitutions: the key should be substituted by the value */
-    private static Map<String, String> spellCheckKeyData;
+    private static volatile Map<String, String> spellCheckKeyData;
     /** The spell check preset values */
-    private static MultiMap<String, String> presetsValueData;
+    private static volatile MultiMap<String, String> presetsValueData;
     /** The TagChecker data */
     private static final List<CheckerData> checkerData = new ArrayList<>();
@@ -364 +364 @@
                 withErrors.put(p, "IPK");
             }
-            if (checkKeys && key.indexOf(' ') >= 0 && !withErrors.contains(p, "IPK")) {
+            if (checkKeys && key != null && key.indexOf(' ') >= 0 && !withErrors.contains(p, "IPK")) {
                 errors.add( new TestError(this, Severity.WARNING, tr("Invalid white space in property key"),
                         tr(s, key), MessageFormat.format(s, key), INVALID_KEY_SPACE, p) );
@@ -379 +379 @@
                 withErrors.put(p, "HTML");
             }
-            if (checkValues && value != null && value.length() > 0 && presetsValueData != null) {
+            if (checkValues && key != null && value != null && value.length() > 0 && presetsValueData != null) {
                 final Set<String> values = presetsValueData.get(key);
                 final boolean keyInPresets = values != null;
@@ -423 +423 @@
                 }
             }
-            if (checkFixmes && value != null && value.length() > 0) {
+            if (checkFixmes && key != null && value != null && value.length() > 0) {
                 if ((value.toLowerCase().contains("fixme")
                         || value.contains("check and delete")

trunk/src/org/openstreetmap/josm/data/validation/util/Entities.java

@@ -334 +334 @@
     };
 
-    private static Map<String, String> mapNameToValue = null;
+    private static volatile Map<String, String> mapNameToValue = null;
 
     public String unescape(String str) {

trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java

@@ -59 +59 @@
      * @return the unique instance of this formatter
      */
-    public static DefaultNameFormatter getInstance() {
+    public static synchronized DefaultNameFormatter getInstance() {
         if (instance == null) {
             instance = new DefaultNameFormatter();
@@ -109 +109 @@
      * @return the list of naming tags used in relations
      */
-    public static List<String> getNamingtagsForRelations() {
+    public static synchronized List<String> getNamingtagsForRelations() {
         if (namingTagsForRelations == null) {
             namingTagsForRelations = new ArrayList<>(

trunk/src/org/openstreetmap/josm/gui/FileDrop.java

@@ -280 +280 @@
     }   // end constructor
 
-    private static boolean supportsDnD()
+    private static synchronized boolean supportsDnD()
     {   // Static Boolean
         if( supportsDnD == null )

trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java

@@ -59 +59 @@
      * @return the unique instance of the JOSM user identity manager
      */
-    public static JosmUserIdentityManager getInstance() {
+    public static synchronized JosmUserIdentityManager getInstance() {
         if (instance == null) {
             instance = new JosmUserIdentityManager();
@@ -283 +283 @@
             if (OsmApi.isUsingOAuth()) {
                 try {
-                    instance.initFromOAuth(Main.parent);
+                    getInstance().initFromOAuth(Main.parent);
                 } catch (Exception e) {
                     Main.error(e);

trunk/src/org/openstreetmap/josm/gui/NotificationManager.java

@@ -76 +76 @@
     private final Color PANEL_OPAQUE = new Color(224, 236, 249);
 
-    public static NotificationManager getInstance() {
+    public static synchronized NotificationManager getInstance() {
         if (INSTANCE == null) {
             INSTANCE = new NotificationManager();

trunk/src/org/openstreetmap/josm/gui/actionsupport/DeleteFromRelationConfirmationDialog.java

@@ -59 +59 @@
      * @return The unique instance of this dialog
      */
-    public static DeleteFromRelationConfirmationDialog getInstance() {
+    public static synchronized DeleteFromRelationConfirmationDialog getInstance() {
         if (instance == null) {
             instance = new DeleteFromRelationConfirmationDialog();

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -100 +100 @@
      */
     @Deprecated
-    public static CombinePrimitiveResolverDialog getInstance() {
+    public static synchronized CombinePrimitiveResolverDialog getInstance() {
         if (instance == null) {
             GuiHelper.runInEDTAndWait(new Runnable() {

trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java

@@ -80 +80 @@
 public class LayerListDialog extends ToggleDialog {
     /** the unique instance of the dialog */
-    private static LayerListDialog instance;
+    private static volatile LayerListDialog instance;
 
     /**

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManager.java

@@ -69 +69 @@
 
     /** the unique instance of the cache manager  */
-    private static ChangesetCacheManager instance;
+    private static volatile ChangesetCacheManager instance;
 
     /**

trunk/src/org/openstreetmap/josm/gui/download/DownloadDialog.java

@@ -60 +60 @@
      * @return the unique instance of the download dialog
      */
-    public static DownloadDialog getInstance() {
+    public static synchronized DownloadDialog getInstance() {
         if (instance == null) {
             instance = new DownloadDialog(Main.parent);

trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java

@@ -72 +72 @@
      * @return the unique instance of the help browser
      */
-    public static HelpBrowser getInstance() {
+    public static synchronized HelpBrowser getInstance() {
         if (instance == null) {
             instance = new HelpBrowser();

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java

@@ -38 +38 @@
      * @return the unique instance
      */
-    public static HistoryBrowserDialogManager getInstance() {
+    public static synchronized HistoryBrowserDialogManager getInstance() {
         if (instance == null) {
             instance = new HistoryBrowserDialogManager();

trunk/src/org/openstreetmap/josm/gui/io/ChangesetCommentModel.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.io;
 
+import java.util.Objects;
 import java.util.Observable;
 
@@ -7 +8 @@
  * ChangesetCommentModel is an observable model for the changeset comment edited
  * in the {@link UploadDialog}.
- *
+ * @since 3133
  */
 public class ChangesetCommentModel extends Observable {
@@ -13 +14 @@
 
     /**
-     * Sets the current changeset comment and notifies observers if the comment
-     * has changed.
+     * Sets the current changeset comment and notifies observers if the comment has changed.
      *
      * @param comment the new upload comment. Empty string assumed if null.
@@ -21 +21 @@
         String oldValue = this.comment;
         this.comment = comment == null ? "" : comment;
-        if (!oldValue.equals(this.comment)) {
+        if (!Objects.equals(oldValue, this.comment)) {
             setChanged();
             notifyObservers(this.comment);

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -74 +74 @@
      * @return the unique instance of the upload dialog
      */
-    public static UploadDialog getUploadDialog() {
+    public static synchronized UploadDialog getUploadDialog() {
         if (uploadDialog == null) {
             uploadDialog = new UploadDialog();

trunk/src/org/openstreetmap/josm/gui/layer/JumpToMarkerActions.java

@@ -27 +27 @@
     }
 
-    private static JumpToNextMarker jumpToNextMarkerAction;
-    private static JumpToPreviousMarker jumpToPreviousMarkerAction;
+    private static volatile JumpToNextMarker jumpToNextMarkerAction;
+    private static volatile JumpToPreviousMarker jumpToPreviousMarkerAction;
 
     public static void initialize() {

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -232 +232 @@
      * a paint texture for non-downloaded area
      */
-    private static TexturePaint hatched;
+    private static volatile TexturePaint hatched;
 
     static {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -902 +902 @@
     }
 
-    private static List<MapMode> supportedMapModes = null;
+    private static volatile List<MapMode> supportedMapModes = null;
 
     /**

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java

@@ -49 +49 @@
 
     // Only one instance of that class is present at one time
-    private static ImageViewerDialog dialog;
+    private static volatile ImageViewerDialog dialog;
 
     private boolean collapseButtonClicked = false;

trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/AudioMarker.java

@@ -23 +23 @@
 
     private URL audioUrl;
-    private static AudioMarker recentlyPlayedMarker = null;
+    private static volatile AudioMarker recentlyPlayedMarker = null;
     public double syncOffset;
     public boolean timeFromAudio = false; // as opposed to from the GPX track

trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/PlayHeadMarker.java

@@ -38 +38 @@
     private Timer timer = null;
     private double animationInterval = 0.0; // seconds
-    private static PlayHeadMarker playHead = null;
+    private static volatile PlayHeadMarker playHead = null;
     private MapMode oldMode = null;
     private LatLon oldCoor;

trunk/src/org/openstreetmap/josm/gui/mappaint/BoxTextElemStyle.java

@@ -172 +172 @@
      * session. There should be preference listener updating this cache.
      */
-    private static Color DEFAULT_TEXT_COLOR = null;
+    private static volatile Color DEFAULT_TEXT_COLOR = null;
     private static void initDefaultParameters() {
         if (DEFAULT_TEXT_COLOR != null) return;

trunk/src/org/openstreetmap/josm/gui/mappaint/StyleSource.java

@@ -135 +135 @@
      * @see #getIconProvider()
      */
-    private static ImageProvider getDefaultIconProvider() {
+    private static synchronized ImageProvider getDefaultIconProvider() {
         if (defaultIconProvider == null) {
             defaultIconProvider = new ImageProvider("dialogs/mappaint", "pencil");

trunk/src/org/openstreetmap/josm/gui/preferences/server/OAuthAccessTokenHolder.java

@@ -21 +21 @@
      * @return The unique instance of {@code OAuthAccessTokenHolder}
      */
-    public static OAuthAccessTokenHolder getInstance() {
+    public static synchronized OAuthAccessTokenHolder getInstance() {
         if (instance == null) {
             instance = new OAuthAccessTokenHolder();

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetNameTemplateList.java

@@ -21 +21 @@
      * @return the unique instance
      */
-    public static TaggingPresetNameTemplateList getInstance() {
+    public static synchronized TaggingPresetNameTemplateList getInstance() {
         if (instance == null) {
             instance = new TaggingPresetNameTemplateList();

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetReader.java

@@ -46 +46 @@
     }
 
-    private static File zipIcons = null;
+    private static volatile File zipIcons = null;
 
     /**

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetSearchDialog.java

@@ -25 +25 @@
      * @return the unique instance of {@code TaggingPresetSearchDialog}.
      */
-    public static TaggingPresetSearchDialog getInstance() {
+    public static synchronized TaggingPresetSearchDialog getInstance() {
         if (instance == null) {
             instance = new TaggingPresetSearchDialog();

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetSearchPrimitiveDialog.java

@@ -1 +1 @@
 package org.openstreetmap.josm.gui.tagging;
+
+import static org.openstreetmap.josm.tools.I18n.tr;
+
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+import java.awt.event.KeyEvent;
+import java.util.HashSet;
 
 import org.openstreetmap.josm.Main;
@@ -7 +14 @@
 import org.openstreetmap.josm.tools.Shortcut;
 import org.openstreetmap.josm.tools.Utils;
-
-import java.awt.event.ActionEvent;
-import java.awt.event.ActionListener;
-import java.awt.event.KeyEvent;
-import java.util.HashSet;
-
-import static org.openstreetmap.josm.tools.I18n.tr;
 
 /**
@@ -29 +29 @@
      * @return the unique instance of {@code TaggingPresetSearchPrimitiveDialog}.
      */
-    public static TaggingPresetSearchPrimitiveDialog getInstance() {
+    public static synchronized TaggingPresetSearchPrimitiveDialog getInstance() {
         if (instance == null) {
             instance = new TaggingPresetSearchPrimitiveDialog();

trunk/src/org/openstreetmap/josm/gui/util/FileFilterAllFiles.java

@@ -10 +10 @@
 /**
  * A FileFilter that accepts all files.
+ * @since 5572
  */
 public class FileFilterAllFiles extends FileFilter {
@@ -15 +16 @@
     private static FileFilterAllFiles INSTANCE;
 
-    public static FileFilterAllFiles getInstance() {
+    /**
+     * Replies the unique instance.
+     * @return the unique instance
+     */
+    public static synchronized FileFilterAllFiles getInstance() {
         if (INSTANCE == null) {
             INSTANCE = new FileFilterAllFiles();

trunk/src/org/openstreetmap/josm/gui/util/StayOpenCheckBoxMenuItem.java

@@ -18 +18 @@
 public class StayOpenCheckBoxMenuItem extends JCheckBoxMenuItem {
 
-  private static MenuElement[] path;
+  private static volatile MenuElement[] path;
 
   {

trunk/src/org/openstreetmap/josm/gui/util/StayOpenMenuItem.java

@@ -17 +17 @@
 public class StayOpenMenuItem extends JMenuItem {
 
-  private static MenuElement[] path;
+  private static volatile MenuElement[] path;
 
   {

trunk/src/org/openstreetmap/josm/gui/util/StayOpenRadioButtonMenuItem.java

@@ -17 +17 @@
 public class StayOpenRadioButtonMenuItem extends JRadioButtonMenuItem {
 
-  private static MenuElement[] path;
+  private static volatile MenuElement[] path;
 
   {

trunk/src/org/openstreetmap/josm/gui/widgets/AbstractFileChooser.java

@@ -16 +16 @@
 
     /** The locale for both implementations */
-    protected static Locale locale;
+    protected static volatile Locale locale;
 
     /**

trunk/src/org/openstreetmap/josm/io/MessageNotifier.java

@@ -50 +50 @@
     private static final Runnable WORKER = new Worker();
 
-    private static ScheduledFuture<?> task = null;
+    private static volatile ScheduledFuture<?> task = null;
 
     private static class Worker implements Runnable {

trunk/src/org/openstreetmap/josm/io/OsmReader.java

@@ -55 +55 @@
 
     /** Used by plugins to register themselves as data postprocessors. */
-    private static List<OsmServerReadPostprocessor> postprocessors;
+    private static volatile List<OsmServerReadPostprocessor> postprocessors;
 
     /** register a new postprocessor */

trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java

@@ -37 +37 @@
     private Collection<OsmPrimitive> processed;
 
-    private static List<OsmServerWritePostprocessor> postprocessors;
+    private static volatile List<OsmServerWritePostprocessor> postprocessors;
     public static void registerPostprocessor(OsmServerWritePostprocessor pp) {
         if (postprocessors == null) {

trunk/src/org/openstreetmap/josm/io/OsmWriterFactory.java

@@ -17 +17 @@
 public class OsmWriterFactory {
 
-    public static OsmWriterFactory theFactory;
+    public static volatile OsmWriterFactory theFactory;
     public static OsmWriter createOsmWriter(PrintWriter out, boolean osmConform, String version) {
         // pre-set factory with this default implementation; can still be overwritten

trunk/src/org/openstreetmap/josm/io/auth/CredentialsManager.java

@@ -20 +20 @@
 public class CredentialsManager implements CredentialsAgent {
 
-    private static CredentialsManager instance;
+    private static volatile CredentialsManager instance;
 
     /**

trunk/src/org/openstreetmap/josm/io/auth/DefaultAuthenticator.java

@@ -16 +16 @@
  */
 public final class DefaultAuthenticator extends Authenticator {
-    private static DefaultAuthenticator instance;
+    private static volatile DefaultAuthenticator instance;
 
     /**

trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpServer.java

@@ -23 +23 @@
     private ServerSocket server;
 
-    private static RemoteControlHttpServer instance;
+    private static volatile RemoteControlHttpServer instance;
 
     /**

trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpsServer.java

@@ -75 +75 @@
     private ServerSocket server;
 
-    private static RemoteControlHttpsServer instance;
+    private static volatile RemoteControlHttpsServer instance;
     private boolean initOK = false;
     private SSLContext sslContext;

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -566 +566 @@
      * @return the class loader
      */
-    public static DynamicURLClassLoader getPluginClassLoader() {
+    public static synchronized DynamicURLClassLoader getPluginClassLoader() {
         if (pluginClassLoader == null) {
             pluginClassLoader = AccessController.doPrivileged(new PrivilegedAction<DynamicURLClassLoader>() {

trunk/src/org/openstreetmap/josm/tools/AudioPlayer.java

@@ -26 +26 @@
 public final class AudioPlayer extends Thread {
 
-    private static AudioPlayer audioPlayer = null;
+    private static volatile AudioPlayer audioPlayer = null;
 
     private enum State { INITIALIZING, NOTPLAYING, PLAYING, PAUSED, INTERRUPTED }

trunk/src/org/openstreetmap/josm/tools/BugReportExceptionHandler.java

@@ -42 +42 @@
 
     private static boolean handlingInProgress = false;
-    private static BugReporterThread bugReporterThread = null;
+    private static volatile BugReporterThread bugReporterThread = null;
     private static int exceptionCounter = 0;
     private static boolean suppressExceptionDialogs = false;

trunk/src/org/openstreetmap/josm/tools/I18n.java

@@ -76 +76 @@
     }
 
-    private static PluralMode pluralMode = PluralMode.MODE_NOTONE; /* english default */
-    private static String loadedCode = "en";
+    private static volatile PluralMode pluralMode = PluralMode.MODE_NOTONE; /* english default */
+    private static volatile String loadedCode = "en";
 
     /* Localization keys for file chooser (and color chooser). */
@@ -164 +164 @@
         "OptionPane.cancelButtonText"
     };
-    private static Map<String, String> strings = null;
-    private static Map<String, String[]> pstrings = null;
+    private static volatile Map<String, String> strings = null;
+    private static volatile Map<String, String[]> pstrings = null;
     private static Map<String, PluralMode> languages = new HashMap<>();
 

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -1356 +1356 @@
     }
 
-    private static SVGUniverse getSvgUniverse() {
+    private static synchronized SVGUniverse getSvgUniverse() {
         if (svgUniverse == null) {
             svgUniverse = new SVGUniverse();

trunk/src/org/openstreetmap/josm/tools/MultikeyActionsHandler.java

@@ -124 +124 @@
      * @return The unique instance of this class
      */
-    public static MultikeyActionsHandler getInstance() {
+    public static synchronized MultikeyActionsHandler getInstance() {
         if (instance == null) {
             instance = new MultikeyActionsHandler();

trunk/src/org/openstreetmap/josm/tools/RightAndLefthandTraffic.java

@@ -7 +7 @@
 import java.util.ArrayList;
 import java.util.Collection;
+
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.osm.BBox;
@@ -47 +48 @@
     }
 
-    private static Collection<Area> leftHandTrafficPolygons;
-    private static GeoPropertyIndex<Boolean> rlCache;
+    private static volatile Collection<Area> leftHandTrafficPolygons;
+    private static volatile GeoPropertyIndex<Boolean> rlCache;
 
     /**