Changeset 7346 in josm

Timestamp:

2014-07-28T22:33:16+02:00 (10 years ago)

Author:

Don-vip

Message:

fix #10207 - UI tuning in menu scroller: ignore JSeparator in scroll count

File:

• trunk/src/org/openstreetmap/josm/gui/MenuScroller.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/gui/MenuScroller.java

@@ -21 +21 @@
 import javax.swing.JMenuItem;
 import javax.swing.JPopupMenu;
+import javax.swing.JSeparator;
 import javax.swing.MenuSelectionManager;
 import javax.swing.Timer;
@@ -83 +84 @@
 
             if (maxHeight > 0) {
-                result = (maxHeight/itemHeight)-2;
+                result = (maxHeight/itemHeight)-1;
             }
         }
@@ -482 +483 @@
     private void refreshMenu() {
         if (menuItems != null && menuItems.length > 0) {
+
+            int numOfNonSepItems = getNumberOfNonSeparatorItems(menuItems);
+
             firstIndex = Math.max(topFixedCount, firstIndex);
-            firstIndex = Math.min(menuItems.length - bottomFixedCount - scrollCount, firstIndex);
+            firstIndex = Math.min(numOfNonSepItems - bottomFixedCount - scrollCount, firstIndex);
 
             upItem.setEnabled(firstIndex > topFixedCount);
-            downItem.setEnabled(firstIndex + scrollCount < menuItems.length - bottomFixedCount);
+            downItem.setEnabled(firstIndex + scrollCount < numOfNonSepItems - bottomFixedCount);
 
             menu.removeAll();
@@ -540 +544 @@
         private void setMenuItems() {
             menuItems = menu.getComponents();
+            int numOfNonSepItems = getNumberOfNonSeparatorItems(menuItems);
             if (keepVisibleIndex >= topFixedCount
-                    && keepVisibleIndex <= menuItems.length - bottomFixedCount
+                    && keepVisibleIndex <= numOfNonSepItems - bottomFixedCount
                     && (keepVisibleIndex > firstIndex + scrollCount
                     || keepVisibleIndex < firstIndex)) {
@@ -547 +552 @@
                 firstIndex = Math.max(firstIndex, keepVisibleIndex - scrollCount + 1);
             }
-            if (menuItems.length > topFixedCount + scrollCount + bottomFixedCount) {
+            if (numOfNonSepItems > topFixedCount + scrollCount + bottomFixedCount) {
                 refreshMenu();
             }
@@ -639 +644 @@
         @Override
         public void mouseWheelMoved(MouseWheelEvent mwe) {
-            if (menu.getComponents().length > scrollCount) {
+            if (getNumberOfNonSeparatorItems(menu.getComponents()) > scrollCount) {
                 firstIndex += mwe.getWheelRotation();
                 refreshMenu();
@@ -646 +651 @@
         }
     }
+
+    private int getNumberOfNonSeparatorItems(Component[] items) {
+        int result = 0;
+        for (Component c : items) {
+            if (!(c instanceof JSeparator)) {
+                result++;
+            }
+        }
+        return result;
+    }
 }