Changeset 7218 in josm for trunk

Timestamp:

2014-06-06T10:30:46+02:00 (10 years ago)

Author:

akks

Message:

fix #3910: toggle lasso mode on repeating S key
can be turned of with mappaint.select.toggle-lasso-on-repeated-S

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/SelectAction.java (modified) (6 diffs)
• gui/MapFrame.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -49 +49 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.util.GuiHelper;
+import org.openstreetmap.josm.gui.util.KeyPressReleaseListener;
 import org.openstreetmap.josm.gui.util.ModifierListener;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -65 +66 @@
  * feature "selection remove" is disabled on this platform.
  */
-public class SelectAction extends MapMode implements ModifierListener, SelectionEnded {
+public class SelectAction extends MapMode implements ModifierListener, KeyPressReleaseListener, SelectionEnded {
     // "select" means the selection rectangle and "move" means either dragging
     // or select if no mouse movement occurs (i.e. just clicking)
@@ -102 +103 @@
 
     private boolean lassoMode = false;
+    public boolean repeatedKeySwitchLassoOption;
 
     // Cache previous mouse event (needed when only the modifier keys are
@@ -182 +184 @@
         initialMoveDelay = Main.pref.getInteger("edit.initial-move-delay", 200);
         initialMoveThreshold = Main.pref.getInteger("edit.initial-move-threshold", 5);
+        repeatedKeySwitchLassoOption = Main.pref.getBoolean("mappaint.select.toggle-lasso-on-repeated-S", true);
         cycleManager.init();
         virtualManager.init();
         // This is required to update the cursors when ctrl/shift/alt is pressed
         Main.map.keyDetector.addModifierListener(this);
+        Main.map.keyDetector.addKeyListener(this);
     }
 
@@ -196 +200 @@
         mv.setVirtualNodesEnabled(false);
         Main.map.keyDetector.removeModifierListener(this);
+        Main.map.keyDetector.removeKeyListener(this);
         removeHighlighting();
     }
@@ -627 +632 @@
         updateKeyModifiers(e);
         selectPrims(selectionManager.getSelectedObjects(alt), true, true);
+    }
+
+    @Override
+    public void doKeyPressed(KeyEvent e) {
+        if (!Main.isDisplayingMapView() ||
+                !repeatedKeySwitchLassoOption || !getShortcut().isEvent(e)) return;
+        e.consume();
+        if (!lassoMode) {
+            Main.map.selectMapMode(Main.map.mapModeSelectLasso);
+        } else {
+            Main.map.selectMapMode(Main.map.mapModeSelect);
+        }
+    }
+
+    @Override
+    public void doKeyReleased(KeyEvent e) {
     }
 

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -135 +135 @@
     // Map modes
     public final SelectAction mapModeSelect;
+    public LassoModeAction mapModeSelectLasso;
+
     private final Map<Layer, MapMode> lastMapMode = new HashMap<>();
     private final MapMode mapModeDraw;
@@ -216 +218 @@
         // toolBarActions, map mode buttons
         addMapMode(new IconToggleButton(mapModeSelect = new SelectAction(this)));
-        addMapMode(new IconToggleButton(new LassoModeAction(), true));
+        addMapMode(new IconToggleButton(mapModeSelectLasso = new LassoModeAction(), true));
         addMapMode(new IconToggleButton(mapModeDraw = new DrawAction(this)));
         addMapMode(new IconToggleButton(mapModeZoom = new ZoomAction(this)));