Changeset 7088 in josm

Timestamp:

2014-05-09T14:15:51+02:00 (10 years ago)

Author:

Don-vip

Message:

more fixes in unit tests

Location:

trunk/test

Files:

• functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java (modified) (4 diffs)
• functional/org/openstreetmap/josm/io/UploadStrategySelectionPanelTest.java (modified) (2 diffs)
• unit/org/openstreetmap/josm/gui/conflict/properties/PropertiesMergeModelTest.java (modified) (4 diffs)

trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java

@@ -17 +17 @@
 import java.text.MessageFormat;
 import java.util.ArrayList;
-import java.util.Properties;
 import java.util.logging.Logger;
 
@@ -110 +109 @@
 
     private static DataSet testDataSet;
-    private static Properties testProperties;
 
     /**
@@ -142 +140 @@
         File dataSetCacheOutputFile = new File(System.getProperty("java.io.tmpdir"), MultiFetchServerObjectReaderTest.class.getName() + ".dataset");
 
-        // make sure we don't upload to production
-        //
-        String url = OsmApi.getOsmApi().getBaseUrl().toLowerCase().trim();
-        if (url.startsWith("http://www.openstreetmap.org") || url.startsWith("http://api.openstreetmap.org")
-            || url.startsWith("https://www.openstreetmap.org") || url.startsWith("https://api.openstreetmap.org")) {
-            fail(MessageFormat.format("configured url ''{0}'' seems to be a productive url, aborting.", url));
-        }
-
         String p = System.getProperties().getProperty("useCachedDataset");
         if (p != null && Boolean.parseBoolean(p.trim().toLowerCase())) {
@@ -188 +178 @@
     @Before
     public void setUp() throws IOException, IllegalDataException {
-        File f = new File(testProperties.getProperty("test.functional.tempdir"), MultiFetchServerObjectReaderTest.class.getName() + ".dataset");
+        File f = new File(System.getProperty("java.io.tmpdir"), MultiFetchServerObjectReaderTest.class.getName() + ".dataset");
         logger.info(MessageFormat.format("reading cached dataset ''{0}''", f.toString()));
         ds = new DataSet();

trunk/test/functional/org/openstreetmap/josm/io/UploadStrategySelectionPanelTest.java

@@ -12 +12 @@
 import javax.swing.JTextField;
 
+import org.junit.Ignore;
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.io.UploadStrategySelectionPanel;
 import org.openstreetmap.josm.gui.progress.NullProgressMonitor;
 
+@Ignore
 public class UploadStrategySelectionPanelTest extends JFrame {
 
@@ -50 +52 @@
         return pnl;
     }
-    
+
     /**
      * Constructs a new {@code UploadStrategySelectionPanelTest}.

trunk/test/unit/org/openstreetmap/josm/gui/conflict/properties/PropertiesMergeModelTest.java

@@ -25 +25 @@
 public class PropertiesMergeModelTest {
 
-    static public class ObserverTest implements Observer {
+    public static abstract class TestObserver implements Observer {
         public int numInvocations;
 
@@ -33 +33 @@
         }
 
-        public void test() {
-        }
+        public abstract void test();
 
         public void assertNumInvocations(int count) {
@@ -112 +111 @@
         // decide KEEP_MINE  and ensure notification via Observable
         //
-        ObserverTest observerTest;
+        TestObserver observerTest;
         model.addObserver(
-                observerTest = new ObserverTest() {
+                observerTest = new TestObserver() {
                     @Override
                     public void test() {
@@ -129 +128 @@
         model.deleteObserver(observerTest);
         model.addObserver(
-                observerTest = new ObserverTest() {
+                observerTest = new TestObserver() {
                     @Override
                     public void test() {