Changeset 7048 in josm for trunk/src/org/openstreetmap

Timestamp:

2014-05-02T02:37:08+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - Throwable and Error classes should not be caught

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/ExtensionFileFilter.java (modified) (2 diffs)
• actions/SessionLoadAction.java (modified) (1 diff)
• data/projection/Projections.java (modified) (1 diff)
• gui/JosmUserIdentityManager.java (modified) (2 diffs)
• gui/preferences/PreferenceTabbedPane.java (modified) (2 diffs)
• plugins/PluginHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/ExtensionFileFilter.java

@@ -64 +64 @@
                 importers.add(importer);
                 MapView.addLayerChangeListener(importer);
-            } catch (Throwable t) {
-                Main.debug(t.getMessage());
+            } catch (Exception e) {
+                Main.debug(e.getMessage());
             }
         }
@@ -85 +85 @@
                 exporters.add(exporter);
                 MapView.addLayerChangeListener(exporter);
-            } catch (Throwable t) {
-                Main.debug(t.getMessage());
+            } catch (Exception e) {
+                Main.debug(e.getMessage());
             }
         }

trunk/src/org/openstreetmap/josm/actions/SessionLoadAction.java

@@ -174 +174 @@
             } catch (IOException e) {
                 handleException(tr("IO Error"), e);
-            } catch (RuntimeException e) {
-                cancel();
-                throw e;
-            } catch (Error e) {
+            } catch (Exception e) {
                 cancel();
                 throw e;

trunk/src/org/openstreetmap/josm/data/projection/Projections.java

@@ -179 +179 @@
             try {
                 proj = pc.getProjection();
-            } catch (Throwable t) {
-                String cause = t.getMessage();
+            } catch (Exception e) {
+                String cause = e.getMessage();
                 Main.warn("Unable to get projection "+code+" with "+pc + (cause != null ? ". "+cause : ""));
             }

trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java

@@ -64 +64 @@
                 try {
                     instance.initFromOAuth(Main.parent);
-                } catch (Throwable t) {
-                    Main.error(t);
+                } catch (Exception e) {
+                    Main.error(e);
                     // Fall back to preferences if OAuth identification fails for any reason
                     instance.initFromPreferences();
@@ -278 +278 @@
                 try {
                     instance.initFromOAuth(Main.parent);
-                } catch (Throwable t) {
-                    Main.error(t);
+                } catch (Exception e) {
+                    Main.error(e);
                 }
             }

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -562 +562 @@
                                 } catch (SecurityException ex) {
                                     Main.error(ex);
-                                } catch (Throwable ex) {
+                                } catch (Exception ex) {
                                     BugReportExceptionHandler.handleException(ex);
                                 } finally {
@@ -576 +576 @@
                 } catch (SecurityException ex) {
                     Main.error(ex);
-                } catch (Throwable ex) {
+                } catch (Exception ex) {
                     // allow to change most settings even if e.g. a plugin fails
                     BugReportExceptionHandler.handleException(ex);

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -571 +571 @@
                         + "Delete from preferences?</html>", plugin.name, plugin.className);
             }
-        }  catch (Throwable e) {
+        }  catch (Exception e) {
             Main.error(e);
         }