Changeset 6990 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2014-04-19T00:36:43+02:00 (11 years ago)

Author:

Don-vip

Message:

sonar - place Strings literals on the left side when checking for equality (can avoid NPEs)

File:

• trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -353 +353 @@
         String policy = Main.pref.get(togglePreferenceKey, "ask");
         policy = policy.trim().toLowerCase();
-        if (policy.equals("never")) {
+        if ("never".equals(policy)) {
             if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
                 Main.info(tr("Skipping plugin update after JOSM upgrade. Automatic update at startup is disabled."));
@@ -362 +362 @@
         }
 
-        if (policy.equals("always")) {
+        if ("always".equals(policy)) {
             if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
                 Main.info(tr("Running plugin update after JOSM upgrade. Automatic update at startup is enabled."));
@@ -371 +371 @@
         }
 
-        if (!policy.equals("ask")) {
+        if (!"ask".equals(policy)) {
             Main.warn(tr("Unexpected value ''{0}'' for preference ''{1}''. Assuming value ''ask''.", policy, togglePreferenceKey));
         }
@@ -1355 +1355 @@
             String policy = Main.pref.get(preferencesKey, "ask");
             policy = policy.trim().toLowerCase();
-            cbDontShowAgain.setSelected(! policy.equals("ask"));
+            cbDontShowAgain.setSelected(!"ask".equals(policy));
         }