Ignore:
Timestamp:
2014-02-25T01:31:24+01:00 (6 years ago)
Author:
Don-vip
Message:

fix some Sonar issues

Location:
trunk/src/org/openstreetmap/josm/io
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/io/auth/AbstractCredentialsAgent.java

    r6087 r6883  
    1010import org.openstreetmap.josm.gui.util.GuiHelper;
    1111
    12 abstract public class AbstractCredentialsAgent implements CredentialsAgent {
     12public abstract class AbstractCredentialsAgent implements CredentialsAgent {
    1313
    1414    protected Map<RequestorType, PasswordAuthentication> memoryCredentialsCache = new HashMap<RequestorType, PasswordAuthentication>();
  • trunk/src/org/openstreetmap/josm/io/auth/CredentialsManager.java

    r6349 r6883  
    2727     * @return the single credential agent used in JOSM
    2828     */
    29     static public CredentialsManager getInstance() {
     29    public static CredentialsManager getInstance() {
    3030        if (instance == null) {
    3131            CredentialsAgent delegate;
  • trunk/src/org/openstreetmap/josm/io/imagery/Grabber.java

    r6643 r6883  
    88import org.openstreetmap.josm.gui.layer.WMSLayer;
    99
    10 abstract public class Grabber implements Runnable {
     10public abstract class Grabber implements Runnable {
    1111    protected final MapView mv;
    1212    protected final WMSLayer layer;
     
    2727        return layer.getBaseImageWidth();
    2828    }
     29
    2930    int height(){
    3031        return layer.getBaseImageHeight();
     
    8182    }
    8283
    83     abstract public boolean loadFromCache(WMSRequest request);
     84    public abstract boolean loadFromCache(WMSRequest request);
    8485
    8586    public void cancel() {
    8687        canceled = true;
    8788    }
    88 
    8989}
  • trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

    r6869 r6883  
    9393     * @return the message
    9494     */
    95     abstract public String getPermissionMessage();
     95    public abstract String getPermissionMessage();
    9696
    9797    /**
     
    105105     * @return the preference name and error message or null
    106106     */
    107     abstract public PermissionPrefWithDefault getPermissionPref();
    108 
    109     abstract public String[] getMandatoryParams();
     107    public abstract PermissionPrefWithDefault getPermissionPref();
     108
     109    public abstract String[] getMandatoryParams();
    110110
    111111    public String[] getOptionalParams() {
     
    137137     * @throws RequestHandlerForbiddenException
    138138     */
    139     final public void checkPermission() throws RequestHandlerForbiddenException
    140     {
     139    public final void checkPermission() throws RequestHandlerForbiddenException {
    141140        /*
    142141         * If the subclass defines a specific preference and if this is set
     
    147146         */
    148147        PermissionPrefWithDefault permissionPref = getPermissionPref();
    149         if((permissionPref != null) && (permissionPref.pref != null))
    150         {
     148        if (permissionPref != null && permissionPref.pref != null) {
    151149            if (!Main.pref.getBoolean(permissionPref.pref, permissionPref.defaultVal)) {
    152150                String err = MessageFormat.format("RemoteControl: ''{0}'' forbidden by preferences", myCommand);
Note: See TracChangeset for help on using the changeset viewer.