Changeset 6821 in josm

Timestamp:

2014-02-07T00:18:58+01:00 (10 years ago)

Author:

bastiK

Message:

see #8902 - Small performance enhancements / coding style (patch by shinigami)

primitives.diff: few optimizations around osm primitives

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/AbstractPrimitive.java (modified) (2 diffs)
• gui/mappaint/xml/Prototype.java (modified) (2 diffs)
• gui/mappaint/xml/XmlCondition.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.data.osm;
+
+import org.openstreetmap.josm.tools.Utils;
 
 import static org.openstreetmap.josm.tools.I18n.tr;
@@ -701 +703 @@
     @Override
     public String getLocalName() {
-        String key = "name:" + Locale.getDefault().toString();
-        if (get(key) != null)
-            return get(key);
-        key = "name:" + Locale.getDefault().getLanguage() + "_" + Locale.getDefault().getCountry();
-        if (get(key) != null)
-            return get(key);
-        key = "name:" + Locale.getDefault().getLanguage();
-        if (get(key) != null)
-            return get(key);
+        final Locale locale = Locale.getDefault();
+        String key = "name:" + locale.toString();
+        String val = get(key);
+        if (val != null)
+            return val;
+
+        final String language = locale.getLanguage();
+        key = "name:" + language + "_" + locale.getCountry();
+        val = get(key);
+        if (val != null)
+            return val;
+
+        key = "name:" + language;
+        val = get(key);
+        if (val != null)
+            return val;
+
         return getName();
+    }
+
+    /**
+     * Tests whether this primitive contains a tag consisting of {@code key} and {@code values}.
+     * @param key the key forming the tag.
+     * @param value value forming the tag.
+     * @return true iff primitive contains a tag consisting of {@code key} and {@code value}.
+     */
+    public boolean hasTag(String key, String value) {
+        return Utils.equal(value, get(key));
     }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/Prototype.java

@@ -25 +25 @@
     public String getCode() {
         if(code == null) {
-            code = "";
-            if (conditions != null) {
+            if (conditions == null || conditions.isEmpty()) {
+                code = "";
+            } else {
+                final StringBuilder sb = new StringBuilder();
                 for(XmlCondition r: conditions) {
-                    code += r.toCode();
+                    r.appendCode(sb);
                 }
+                code = sb.toString();
             }
         }
@@ -42 +45 @@
         {
             String k = primitive.get(r.key);
+
+            if (k == null || (r.value != null && !k.equals(r.value)))
+                return false;
+
             String bv = OsmUtils.getNamedOsmBoolean(r.boolValue);
-            if(k == null || (r.value != null && !k.equals(r.value))
-                    || (bv != null && !bv.equals(OsmUtils.getNamedOsmBoolean(k))))
+
+            if (bv != null && !bv.equals(OsmUtils.getNamedOsmBoolean(k)))
                 return false;
         }

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java

@@ -38 +38 @@
       return "Rule["+key+","+(boolValue != null ? "b="+boolValue:"v="+value)+"]";
     }
-    public String toCode()
+
+    public void appendCode(StringBuilder sb)
     {
-      return "[k="+key+(boolValue != null ? ",b="+boolValue:",v="+value)+"]";
+        sb.append("[k=").append(key);
+
+        if (boolValue != null)
+            sb.append(",b=").append(boolValue);
+        else
+            sb.append(",v=").append(value);
+
+        sb.append("]");
     }
 }