Changeset 6808 in josm for trunk/src

Timestamp:

2014-02-04T00:21:44+01:00 (10 years ago)

Author:

Don-vip

Message:

fix #9675 - allow resize of "add tag" dialog

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -414 +414 @@
         @Override
         public void setupDialog() {
-            setResizable(false);
             super.setupDialog();
+            final Dimension size = getSize();
+            // Set resizable only in width
+            setMinimumSize(size);
+            setPreferredSize(size);
+            // setMaximumSize does not work, and never worked, but still it seems not to bother Oracle to fix this 10-year-old bug
+            // https://bugs.openjdk.java.net/browse/JDK-6200438
+            // https://bugs.openjdk.java.net/browse/JDK-6464548
             
             setRememberWindowGeometry(getClass().getName() + ".geometry",
-                WindowGeometry.centerInWindow(Main.parent, getSize()));
+                WindowGeometry.centerInWindow(Main.parent, size));
         }
 
         @Override
         public void setVisible(boolean visible) {
-            // Do not want dialog to be resizable, but its size may increase each time because of the recently added tags
+            // Do not want dialog to be resizable in height, as its size may increase each time because of the recently added tags
             // So need to modify the stored geometry (size part only) in order to use the automatic positioning mechanism
             if (visible) {
                 WindowGeometry geometry = initWindowGeometry();
                 Dimension storedSize = geometry.getSize();
-                if (!storedSize.equals(getSize())) {
-                    storedSize.setSize(getSize());
+                Dimension size = getSize();
+                if (!storedSize.equals(size)) {
+                    if (storedSize.width < size.width) {
+                        storedSize.width = size.width;
+                    }
+                    if (storedSize.height != size.height) {
+                        storedSize.height = size.height;
+                    }
                     rememberWindowGeometry(geometry);
                 }
@@ -617 +629 @@
             }
             JOptionPane.showMessageDialog(this, tr("Please enter integer number between 0 and {0}", MAX_LRU_TAGS_NUMBER));
-            
         }
         
@@ -757 +768 @@
             }
         }
-
     }
  }