Changeset 6744 in josm for trunk/src/org

Timestamp:

2014-01-19T22:11:57+01:00 (10 years ago)

Author:

simon04

Message:

fix #8032 - Search history loses entries when re-using queries

File:

• trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -20 +20 @@
 import java.util.Collections;
 import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.LinkedList;
 import java.util.List;
@@ -100 +101 @@
         if(searchHistory.isEmpty() || !s.equals(searchHistory.getFirst())) {
             searchHistory.addFirst(new SearchSetting(s));
+        } else if (searchHistory.contains(s)) {
+            // move existing entry to front, fixes #8032 - search history loses entries when re-using queries
+            searchHistory.remove(s);
+            searchHistory.addFirst(new SearchSetting(s));
         }
         int maxsize = Main.pref.getInteger("search.history-size", DEFAULT_SEARCH_HISTORY_SIZE);
@@ -105 +110 @@
             searchHistory.removeLast();
         }
-        List<String> savedHistory = new ArrayList<String>(searchHistory.size());
+        LinkedHashSet<String> savedHistory = new LinkedHashSet<String>(searchHistory.size());
         for (SearchSetting item: searchHistory) {
             savedHistory.add(item.writeToString());